search

Bionus / imgbrd-grabber

Very customizable imageboard/booru downloader with powerful filenaming features.
https://www.bionus.org/imgbrd-grabber/
Apache License 2.0
2.55k stars 216 forks source link

Buggy Grabber #1697

Closed Axelrhode closed 5 years ago

Axelrhode commented 5 years ago

Bug description

Just as the title says, the app is buggy for me. The bugs happen to gelbooru, sankakucomplex, rule34, danbooru, and safebooru (ones I've tried so far). Said bugs are:

  1. Loading images after clicking another thumbnail would load the previously loaded image (happens 70% of the time for me). The tags also change to the ones previously loaded, depending on the image it loads. Downloading the image I tried to load from the previous thumbnail would just say that the image already exists, and trying to download the image while it's loading would yield the same result. Screenshot (324) Screenshot (323) Screenshot (322)

  2. When downloading bulk images, grabber would say that the images already exist (99% of the images, at that). I checked the folder, none. Only those I saw checked on the download list were there. The file names are also blank, despite having set the default names with %md5%.%ext%. Screenshot (230) Screenshot (229) Screenshot (260)

Expected behavior

  1. I expected that the images being loaded would be the ones I clicked after the switch, but no, it loads the previous image. The same image I loaded would be the one I'll be seeing for the next set of images I try to load.

  2. The first time I tried bulk downloading(which was yesterday), it worked for around 95% the images I tried (source was at Gelbooru and Danbooru that time). Today, I can't even download anywhere near the same percentage.

Context

main, settings, + bug.zip

System information

Bionus commented 5 years ago

It seems to me that both of your bugs are linked.

Grabber has an internal MD5 database, so when you save an image, Grabber will make an association "MD5 -> file path". So later on, if the same MD5 is found, it will simply load the image from the file instead of downloading it again.

In your log, it corresponds to:

Image loaded from the file `C:/Users/Computer/Desktop/Grabber/.jpg`

So the issue here is that Grabber seem to fail to load the MD5 for Gelbooru (and others). I can't see any reason for that from your logs, nor can I reproduce on my end, so I'll investigate more to see what might cause that.

What's even stranger, is that if Grabber fails to load the MD5, it should fallback to calculating it itself. 🤔

Axelrhode commented 5 years ago

It was working fine the first day. I have a bunch downloaded here in batch after I got to know how, but after trying on the succeeding day, it just won't work like before.

I hope a fix will come. Thanks for looking into it

Axelrhode commented 5 years ago

Ok so after a few tweaking I did this day, I found out that I had to set the limit to 0. Now, my grabber's not bugging out... All my issues got solved after this thing I did

image image image image

Edit:

Forgot to add images about bulk downloading. But as what was previously stated, it works now. image