search

Bionus / imgbrd-grabber

Very customizable imageboard/booru downloader with powerful filenaming features.
https://www.bionus.org/imgbrd-grabber/
Apache License 2.0
2.55k stars 216 forks source link

Video files do not download correctly from favorites on rule34.xxx #2691

Open PieceOfSoakedIdiotBread opened 2 years ago

PieceOfSoakedIdiotBread commented 2 years ago

Bug description

When searching for a user's favorites from the source api.rule34.xxx with the tag "fav:USER_ID" or through a URL, video files will only display their sample image, viewing the file or saving/downloading the files still results in just the sample image being downloaded.

Steps to reproduce

  1. Enable the source "api.rule34.xxx"
  2. Search for a user's favorites ("fav:USER_ID" or through the URL, they produce the same results)
  3. Click a video (.webm) file and view it and/or download it

Expected behavior

The video is correctly displayed and downloaded as a .webm or .mp4 file.

Current behavior

The sample file for the video is displayed and downloaded instead.

Context

settings.txt

main.log

Recording

Here is a recording of the bug. (no nudity but marking it NSFW JIC)

https://drive.google.com/file/d/1mIWVtGJnOIIsHIEbkEpzyfb3WeXgy6gF/view?usp=sharing

System information

Additional context

In the "details" section of a video file, the URL link correctly displays the video file on the rule34.xxx website, and the header says the video file is a ".webm" so it seems close to fetching the actual video, it may just need some sort of redirect to fetch it.

Bionus commented 2 years ago

Interesting, I just tried with your settings file on a fresh 7.8.1 install to load the file you used in your video and it loaded and saved as a video properly (as well as a few other videos). 🤔

Did you change anything in your source settings? Anything in C:\Users\%USERNAME%\AppData\Local\Bionus\Grabber\sites\Gelbooru (0.2)\api.rule34.xxx\settings.ini? (it should be pretty much empty if you're using only the default settings) Note: don't upload this file if it contains your credentials, or at least hide them first.

Are you still able to reproduce with that specific file? Also with the nightly version?

PieceOfSoakedIdiotBread commented 2 years ago

The bug doesn't appear to be related the the source list, as it occured before then, but to be certain I deleted the source file for api.rule34.xxx in the appdata folder, the bug still occurs. I also uninstalled the program, and then installed the nightly build linked here, and the bug persists.

This is just a guess, but it seems like the issue lies with how website "rule34.xxx" handles user favorites. The issue only occurs on that website and not on others, and it is only when attempting to grab a user's favorites from the site through "fav:USER_ID" or through a URL. When using regular tags, videos will display and download correctly. Also, when using a URL to grab a user's favorites, the bug appears to slightly worsen, as videos will also occasionally be incorrectly listed as .png or .jpg files in the titlebar, however in the "details" window, the page URL still works.

azX2IWOSz2

(Screenshot of the nightly build and the bug.)

QwerploAnon commented 1 year ago

Having this issue as well I'm assuming it's just an API issue huh