search

Bionus / imgbrd-grabber

Very customizable imageboard/booru downloader with powerful filenaming features.
https://www.bionus.org/imgbrd-grabber/
Apache License 2.0
2.55k stars 216 forks source link

Low quality thumbnail scaling #2821

Open temp7t opened 2 years ago

temp7t commented 2 years ago

Bug description

When the thumbnail scaling is higher than 100% the images become very low quality/pixelated. I'm not sure this is a bug, but if it's not please i'd like someone to help me figure out how to get them to be the highest quality possible (the scaling i'd like to use is 500%) even if it means that the thumbnail images load the original images instead of the previews.

Screenshots

If applicable, add screenshots to help explain your problem.

System information

Screenshots image

Additional Info

main.log settings.txt

Bionus commented 1 year ago

It's actually not a bug, since Grabber loads the thumbnails for the listing view. Those are usually 150~200px squares, so if you upscale them 500% they'll definitely be blurry.

What you'd need is more like loading the sample size of images (usually around 1200px biggest side), which I guess is do-able but not all sources have those unfortunately. I'm open it it, but I'm not sure about the performance impact and increased load on the servers.

Laesx commented 1 year ago

It's actually not a bug, since Grabber loads the thumbnails for the listing view. Those are usually 150~200px squares, so if you upscale them 500% they'll definitely be blurry.

What you'd need is more like loading the sample size of images (usually around 1200px biggest side), which I guess is do-able but not all sources have those unfortunately. I'm open it it, but I'm not sure about the performance impact and increased load on the servers.

Danbooru has some webp thumbnails, like this one = https://cdn.donmai.us/720x720/88/f0/88f04c5d8f0c6b6abacb33e86162ccec.webp they appear on their own webpage search results when you set thumbnails to big, but I'm not sure how you pull them with the API, not even sure if you can honestly since it appears to only answers with the 200 or so px thumbnail.

this is the main picture for that thumbnail for example https://cdn.donmai.us/original/88/f0/__wakamo_blue_archive__88f04c5d8f0c6b6abacb33e86162ccec.jpg seems like they change original to 720x720 remove the fancy naming before the md5 and it's a webp, regular thumbnails which is what the api answers and grabber uses work similarly https://cdn.donmai.us/preview/88/f0/88f04c5d8f0c6b6abacb33e86162ccec.jpg although they're "preview" instead of 720x720 and jpg, there's also 360x360 also jpg, which should just require changing "preview" to "360x360" https://cdn.donmai.us/360x360/88/f0/88f04c5d8f0c6b6abacb33e86162ccec.jpg so that shouldn't be super hard to implement(?). I don't know if this works on other Danbooru2 Boards but could be worth looking into.