search

Bionus / imgbrd-grabber

Very customizable imageboard/booru downloader with powerful filenaming features.
https://www.bionus.org/imgbrd-grabber/
Apache License 2.0
2.58k stars 220 forks source link

Adding new Favorites to large Favorites list hangs the Grabber process temporarily #2963

Open VeggieJay opened 1 year ago

VeggieJay commented 1 year ago

Bug description

With a large favorites list ~4000 entries, adding additional favorites hangs the process temporarily for 6-7 seconds. If the Favorites sidebar is open (View->Favorites) then this extends to 10-15 seconds.

Steps to reproduce

  1. View->Favorites to bring up sidebar
  2. Go to Search, add any tag when you have a long Favorites list
  3. (Not Responding)

Expected behavior

Being able to add/remove favorites without any delays

Context

My current favorites.json is about 520kb and 3900 entries Sorry can't provide it out of shame

Screenshots

Grabber Not Responding Sidebar example

System information

Bionus commented 1 year ago

Could be fixed by using proper model/views for favorites in the UI as it seems most of the time spent is done by Qt rendering new widgets created when refreshing the favorites lists.

GregRGM commented 1 year ago

Opening any favorite page causes hanging(Not Responding) and eventually crashing. Even tried this after removing some favorites.

Any other workarounds?