search

Bionus / imgbrd-grabber

Very customizable imageboard/booru downloader with powerful filenaming features.
https://www.bionus.org/imgbrd-grabber/
Apache License 2.0
2.55k stars 218 forks source link

Intermittent Crashing during Downloads with "Error renaming from..." relating to .tmp and Shortcuts/Hardlinks #2965

Open VeggieJay opened 1 year ago

VeggieJay commented 1 year ago

Steps to reproduce

  1. Save Settings: If a file already exists globally -> Shortcut (or Hard link)
  2. Perform Batch Download where a file already exists elsewhere
  3. Error occurs. Sometimes program crashes to desktop and sometimes I can sometimes acknowledge and hit skip to continue the batch download from the next image.
  4. Sometimes download completes with errors and instead the crash occurs when retrying download on the failed images

Context Crashed with shortcut error: crash1_main.log

Crashed with Hard link error: crash2_main.log

In this log, I performed a batch download, had 3 file errors at the end and the program prompted me to retry the download on those files. I hit Yes and the program crashed

settings.ini.txt

I had the option set to Hard Links and ran into the file system limitation, however this was just an experiment and I normally have the option set to shortcuts. With shortcuts I still get crashes with this sort of error:

[20:21:25.631][Info] Creating link for S:/Grabber/.jpg in S:\Grabber\.jpeg.tmp [20:21:25.786][Error] Error renaming from S:/Grabber/.jpeg.tmp.lnk to S:\Grabber\.jpeg.lnk [20:21:25.787][Info] Pausing downloads...

I see the note about the Crash Report tool, if needed, where do I find that?

Screenshots

image

System information

VeggieJay commented 1 year ago

Not sure if it helps but I just crashed from this again so I grabbed the event viewer log

Faulting application name: Grabber.exe, version: 0.0.0.0, time stamp: 0x643e6c3d Faulting module name: Qt5Core.dll, version: 5.15.2.0, time stamp: 0x5fa4dd3b Exception code: 0xc0000005 Fault offset: 0x000000000006a2e9 Faulting process id: 0x16e8 Faulting application start time: 0x01d994b920b70ce1 Faulting application path: C:\Program Files\Grabber\Grabber.exe Faulting module path: C:\Program Files\Grabber\Qt5Core.dll Report Id: 123c9636-5fbc-47e6-ae53-14e249b48187 Faulting package full name: Faulting package-relative application ID: