search

Bionus / imgbrd-grabber

Very customizable imageboard/booru downloader with powerful filenaming features.
https://www.bionus.org/imgbrd-grabber/
Apache License 2.0
2.58k stars 220 forks source link

"Last Success" doesn't seem to account for empty sources with no error. #3251

Open ProtagNeptune opened 4 months ago

ProtagNeptune commented 4 months ago

My Grabber Install with the post-filters !("animated"|"animated_gif"|"animated_png")&(ext:avif|ext:gif|ext:jxl|ext:png|ext:webp)|(ext:bmp|ext:jpe|ext:jpeg|ext:jpg): image

My Grabber Portable with the post-filters ("animated"|"animated_gif"|"animated_png")&(ext:avif|ext:gif|ext:jxl|ext:png|ext:webp)|(ext:mp4|ext:swf|ext:webm|ext:zip): image

A small excerpt from monitors.json:

{
    "monitors": [
        {
            "cumulated": 0,
            "delay": 86400,
            "download": true,
            "filenameOverride": "",
            "getBlacklisted": false,
            "interval": 604800,
            "lastCheck": "1970-01-01T00:00:00Z",
            "lastState": {
                "count": 0,
                "since": "",
                "state": ""
            },
            "lastSuccess": "",
            "notify": false,
            "pathOverride": "C:\\Users\\jelly\\Grabber\\#Monitors\\JackTheRipper",
            "postFilters": [""],
            "preciseCumulated": true,
            "query": {
                "tags": [
                    "jack_the_ripper_(fate/apocrypha)"
                ]
            },
            "sites": [
                "aibooru.online",
                "behoimi.org",
                "booru.allthefallen.moe",
                "danbooru.donmai.us",
                "gelbooru.com",
                "hypnohub.net",
                "konachan.com",
                "rule34.xxx",
                "tbib.org",
                "yande.re"
            ]
        }
    ],
    "version": 1
}
Bionus commented 4 months ago

Yes, no results are considered an error, as it's unexpected to have a monitor with no results at all. Why are you monitoring a search that doesn't bring any results? In case it starts having some one day?

The most common reason this happens is when a tag has been renamed for example, hence why it's not considered a success 🤔

ProtagNeptune commented 4 months ago

In case it starts having some one day?

Yep.

Bionus commented 4 months ago

Then TBH it doesn't really matter if it's flagged as an error or not. The "last success" time is only used for skipping images older than it, after all.

Although I guess I could change the icon to a ⚠️ instead since it's not strictly an error either.

ProtagNeptune commented 4 months ago

I mean, it successfully got images without error: