search

Bionus / imgbrd-grabber

Very customizable imageboard/booru downloader with powerful filenaming features.
https://www.bionus.org/imgbrd-grabber/
Apache License 2.0
2.55k stars 216 forks source link

up to now, just 2 crash! #57

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 9 years ago

First to download ^^

Thanks you for your hard work and this nice piece of software!

I have been able to crash the grabber 2 time. do not really know what made it crash, I was just typing tags to make them into download jobs. I also used 'status:deleted' as a second tag. I was typing the tag always in the same tab. never opening any image window. it seemed to crash when pressing 'enter' key will continue to keep you informed if I find something new.

losing all my download job list each time was quite annoying ^^;

What version of the product are you using? On what operating system?

3.0.0 on XP

Please provide any additional information below.

I have see a few new option here and there, I will 'chipote' with them a bit

(Also, it was also the case in 2.4.0, but thedoujin board never gave any kind of answer. it seem to be a real different kind of board)

Original issue reported on code.google.com by ser...@hotmail.com on 22 Jan 2012 at 9:35

GoogleCodeExporter commented 9 years ago

I forgot 1 detail about crash: I search, with the same tag, on 2 different board almost all the time (danbooru, gelbooru)

Original comment by ser...@hotmail.com on 22 Jan 2012 at 9:38

GoogleCodeExporter commented 9 years ago

Baw... First download, two crashes. :-( I'll look at this ASAP.

Original comment by bio.nus@hotmail.fr on 22 Jan 2012 at 10:03

GoogleCodeExporter commented 9 years ago

Do not be sad ^^ your soft is a real marvel as it is! and I find it really useful and really well done.

you are alone, you do not have a team behind you like for those big companies.

about the crash. I think that bug was already there in the previous version. but it was hidden by the most obvious crash bug (crash when running a second download session).

I will try to be the most helpful that I could. (but, no crash log!)

above all of that : thanks for the grabber

Original comment by ser...@hotmail.com on 22 Jan 2012 at 10:08

GoogleCodeExporter commented 9 years ago

btw, I must be at my third or 4rth crash now ^^;;;; but I got the habit to use the save feature in the download tab

no more download job lost

Original comment by ser...@hotmail.com on 22 Jan 2012 at 10:10

GoogleCodeExporter commented 9 years ago

Can't reproduce your bug. What exact searches/batches make it crash?

BTW, batch autosave coming in 3.1.0. ^^ And for TheDoujin, it seems they totally changed their site. It used to be a gelbooru-based board.

thanks for the grabber

You're welcome :D

Original comment by bio.nus@hotmail.fr on 22 Jan 2012 at 10:23

GoogleCodeExporter commented 9 years ago

I tried to make the grabber crash on purpose... reproducing exactly what I remembered before the crash. (it was some search on mezzo_forte, getting the pages for download, adding status:deleted tag to mezzo_forte, adding to download list, going to another search, etc ...)

but I was unable to make it crash at will XD

at least it was more easy to make 2.4.0 crash. ;P

the problem with undetectable crash, ... they are hard to fix and also, ... you never know when it will happen using the software :/

I often go to those boards, so I will heavily use your grabber. If there was some kind of 'crash log', I would have no problem uploading them for you.

whatever, I will stay alert to any new crash and try to figure out what happened.

see you soon then ^^

thanks again

Original comment by ser...@hotmail.com on 22 Jan 2012 at 10:32

GoogleCodeExporter commented 9 years ago

Ouf, from what you said I thought it was crashing every two searches xP

I also looked in adding a crash reporter, but it was quite a hassle to do. However, I'll add a feature to save the log automatically in 3.0.1, so it will say what was happening before the crash. :)

Original comment by bio.nus@hotmail.fr on 22 Jan 2012 at 10:49

GoogleCodeExporter commented 9 years ago

sorry to have alarmed you! XD no, the program is quite usable.

I also discovered that it does not like too long downloads (36 download jobs, more than 2000 images to download) at one point, it hang (does not respond), then crash. (god bless the save feature ^^)

For future release, about that crash safety feature we talked about in a previous post (tags and download job list autosave): it would be nice to add the finished download job in the crash safety : that way, if it crash, imgbrd-grabber, will also remember which jobs as been done, and will not download them again.

BTW, where is located the Log after crash? I would like to read it (even share it with you).

Original comment by ser...@hotmail.com on 23 Jan 2012 at 11:31

GoogleCodeExporter commented 9 years ago

I also discovered that it does not like too long downloads (36 download jobs, more than 2000 images to download)

2,000 images should be ok though. I'll look at this soon.

it would be nice to add the finished download job in the crash safety : that way, if it crash, imgbrd-grabber, will also remember which jobs as been done, and will not download them again.

Yeah, I agree with you. I'll see what I can do :)

BTW, where is located the Log after crash? I would like to read it (even share it with you).

Seems I forgot a little something. It doesn't works when the program is installed in Program Files. :X Fixed in 3.0.3. Log should save in "C:\Users\%USERNAME%\Grabber".

Original comment by bio.nus@hotmail.fr on 23 Jan 2012 at 11:46

GoogleCodeExporter commented 9 years ago

about long download : using 3.0.4 using Windows Vista (I tought this computer was XP, but no, it is vista)

all my long download failed:

  1. download hang. no visible activity for a long time
  2. it stop between 400 and 600+ images
  3. I cancel, often resulting in a crash. (once, crashed before canceling)

other details that might influence :

Filename : %search_1%/%website%/[%artist%] %id% (%copyright% (%character%)) %md5%.%ext% from time to time, filename are too long, grabber save my files in alternate shortened directories.

I often use the tag status:deleted

Original comment by ser...@hotmail.com on 23 Jan 2012 at 3:09

GoogleCodeExporter commented 9 years ago

More test:

grabber, can not go further than 450 downloaded files (on my vista (about 5 years old) computer) then hang and often crash. it was only able to go up to 600 when I started again a job, and it was just skipping files already existing.

for brand new job, it once hang at 422, and now, 417. 400 and a few seem to be a bugging limit on my computer.

I also figured that a few images have 0k size.

Original comment by ser...@hotmail.com on 23 Jan 2012 at 11:12

GoogleCodeExporter commented 9 years ago

That's a shame for a batch image downloader :/ I'll see what I can do to fix it ASAP.

I also figured that a few images have 0k size.

Do they have any common points, or is it random?

Original comment by bio.nus@hotmail.fr on 23 Jan 2012 at 11:19

  • Added labels: Priority-Critical
  • Removed labels: Priority-Medium
GoogleCodeExporter commented 9 years ago

0k images might be connected to the 'hang' bug I'll keep collecting informations as I download more images ^^

thanks for your great product

Original comment by ser...@hotmail.com on 23 Jan 2012 at 11:23