BioplatformsAustralia / bpaotu

OTU database access for the Australian Microbiome
GNU Affero General Public License v3.0
5 stars 1 forks source link

Need more sensible defaults for taxonomy dropdown, or maybe require explicit choice #204

Open hou098 opened 2 years ago

hou098 commented 2 years ago

From: Mark Brown oceanmicrobes@gmail.com

When the page loads there are pre-loaded choices in the amplicon and. taxonomy (screenshot attached)- turns out they are for. 16S bacteria and PR2....so that is a bit dodgy if like me people look at one and not the other....taking. the "default" setting if you will..... If you can stop that pre-loading then I think people will be fine not deliberately choosing that combination when they have to choose from a dropdown menu...

abissett commented 2 years ago

we should check, but my memory is that something needs to be “pre-loaded” or the plots pages won’t work……..So we it’d be better to change the “default” (to Silva138Wang, which used to be the only option), rather than remove it, unless we add some flag/note/pop-up that tells the user they NEED to select some taxonomy

hou098 commented 2 years ago

we should check, but my memory is that something needs to be “pre-loaded” or the plots pages won’t work

That sounds about right. From looking at the code and git logs, I think the requirement that an amplicon be selected at all times has been added at some point, probably to address that problem. For instance, there's a "--" entry for amplicon selection, but selecting it immediately re-selects the default amplicon. There are also bits of code that check for "no amplicon selected", but that can never be the case now.