BioplatformsAustralia / bpaotu

OTU database access for the Australian Microbiome
GNU Affero General Public License v3.0
5 stars 1 forks source link

Amplicon selection is carried over to metagenome selection #233

Closed Smithmania closed 2 years ago

Smithmania commented 2 years ago

switching from amplicon search mode to metagenome mode, the Interactive graph search retains the amplicon type as a filter e.g., Amplicon ITS1FITS4_fungi_ITS1. With the taxonomy selection being metaxa

I think the following behaviour is associated ...
Selecting interactive graph brings up graphs for the search (amplicon, taxonomy etc) but selection of taxonomy from the dropdown and using the interactive graph search results in the spinning DNA icon for a long time, I used the search: Kingdom is Bacteria Phylum is Cyanobacteria Class is Cyanobacteria Order is Subgroup1

If you clear the taxonomy search the Amplicon filter is removed and the search options appear too be normal behaviour

hou098 commented 2 years ago

I'm pretty sure this is cosmetic: i.e. the amplicon filter is displayed but has no effect in metagenome mode. That means it should be easy to fix.

Smithmania commented 2 years ago

I think there could be something else going on. If you try the same search I did above I get the spinning double helix that goes on forever. The same search on the amplicon page with metaxa selected as the amplicon the search is snappy. It also seems to run ok on both the metagenome and amplicon pages on http://oa-74-cdc.it.csiro.au:3000/

Smithmania commented 2 years ago

It looks like its hanging because order subgroup1 isnt contained in the samples loaded into the metagenome section. So the selections for the metaxa taxonomy dropdowns are based on the whole metaxa dataset

hou098 commented 2 years ago

OK, looks like a separate bug. See https://github.com/BioplatformsAustralia/bpaotu/issues/234 (Fixed by 27dfa7707c317fcfdd0f83e09275b7162ad83446)

hou098 commented 2 years ago

Fixed by https://github.com/BioplatformsAustralia/bpaotu/commit/e3f3a20cb15347de2ac24ae7f06dee8f47575477