BioplatformsAustralia / bpaotu

OTU database access for the Australian Microbiome
GNU Affero General Public License v3.0
5 stars 1 forks source link

Using old versions of Django, sqlalchemy, React etc. #244

Open hou098 opened 1 year ago

hou098 commented 1 year ago

A lot of the dependencies in https://github.com/BioplatformsAustralia/bpaotu/blob/master/requirements/runtime-requirements.txt and https://github.com/BioplatformsAustralia/bpaotu/blob/master/frontend/package.json are out of maintenance

hou098 commented 1 year ago

Also check https://github.com/BioplatformsAustralia/bpaotu/blob/master/requirements/runtime-requirements.txt#L31

git+https://github.com/BioplatformsAustralia/ckanapi.git@streaming-uploads

Can we use a more recent non-forked ckanapi? See https://github.com/BioplatformsAustralia/ckanapi/commit/4a9cf7722418b8f3c84a71fb12943a8b8adf96d7

mtearle commented 1 year ago

BPA Internal Trello reference - https://trello.com/c/hLriKuEZ/1413-update-ckanapi-to-upstream

mtearle commented 1 year ago

I've had a quick look at the branch. of ckanapi Merging upstream into that branch produces a couple of conflicts. I'll need to have closer look and see where that branch is being used in the BPA code bases.

hou098 commented 1 year ago

@mtearle : OK. My motivation for wanting to use a newer ckanapi is this: https://github.com/BioplatformsAustralia/bpaotu/blob/a1c82f41758127ae5526e741bef870ef1825712e/bpaotu/bpaotu/views.py#L1084 Not crucial though.

mtearle commented 1 year ago

@hou098

I've done a quick check across the BPA github repos and the streaming-uploads branch of ckanapi is used almost everywhere. I'll pull in upstream to that branch so we can move into the future for ckanapi and it's dependencies. (either Friday or early next week given workloads)

mtearle commented 1 year ago

@mtearle : OK. My motivation for wanting to use a newer ckanapi is this:

https://github.com/BioplatformsAustralia/bpaotu/blob/a1c82f41758127ae5526e741bef870ef1825712e/bpaotu/bpaotu/views.py#L1084

Not crucial though.

I'll also look at cherry-picking ckan/ckan#5490 and it's associated PR ckan/ckan#6338 into BPA CKAN (as now is an opportune time to do that)

mtearle commented 1 year ago

I've updated ckanapi and the streaming-uploads branch. I've updated bpa-ingest with the new dependency as well.

I'll look at cherry-picking those CKAN changes next

mtearle commented 1 year ago

I've cherry picked ckan/ckan#5490 onto the BPA CKAN install. This should now be working in staging.

hou098 commented 1 year ago

From https://github.com/BioplatformsAustralia/bpaotu/issues/220 (closed as duplicate of this issue)

Bitrot is setting in.