Open IstuntmanI opened 6 years ago
Incorrect
The user can add a server if it cant be pinged. Thats wanted.
Oh. That's what I missed. :grin:
Sooo, i don't really want constantly write to / read from the USERDATA.dat
file. I have thought about an optional import / export option somewhere. The question is how advanced it should be. i thought about somekind of double list component where you can select servers and drag and drop them into the other list... i dunno, would that be an idea?
That's nice. There should also be "import all" and "export all" buttons. Also, in application's favourite tab you should also be able to drag and drop servers to reorder them.
You may create a seperate issue for that :)
So it will be easier to handle the favourites. It should use the same favourites list as the samp.exe browser. Looks like you already did most of the work for this, but for some reason you forgot to finish it.
Also: https://github.com/Bios-Marcel/ServerBrowser/blob/ad937d4c616e75d922275039628e0eafc8eb6b55/client/src/main/java/com/msc/serverbrowser/data/FavouritesController.java#L43-L76
It looks like you should just
return
without actually callingaddServerToFavourites(server);
if that exception is caught. If I'm not missing anything.