Bios-Marcel / cordless

The Discord terminal client you never knew you wanted.
BSD 3-Clause "New" or "Revised" License
1.65k stars 140 forks source link

[REQUEST] Open hyperlinks with ctrl+left click #226

Open koaie opened 4 years ago

koaie commented 4 years ago

What do you want

Open hyperlinks with ctrl+left click

Why

It would make the quality of life with cordless a lot better, by making it easier and simpler to see images, gifs and vidoes.

Bios-Marcel commented 4 years ago

This is usually the terminals job. You might want to see if you can get a better terminal for now. But yeah, I might look into this.

koaie commented 4 years ago

Can confirm not working with xfce4-terminal,kitty, and xterm. on my end at least

Bios-Marcel commented 4 years ago

I personally use Termite and can recommend it warmheartedly :D

Dune-jr commented 4 years ago

I came here to open a ticket about that, and I saw just this one :) My terminal is well capable of ctrl+clicking on links (GNOME Terminal 3.28, Ubuntu's), but unfortunately, it very often cuts the link:

image

The underline part is the one that my mouse is hovering on:

image

and so it opens https://cdn.discordapp/ :(

avahe-kellenberger commented 4 years ago

A partial solution is to enable link shortening in the settings. The links will be shorter, and not wrap around most of the time

Dune-jr commented 4 years ago

Is it the terminal that wraps the line weirdly like this? It doesn't seem like it to me

image

Bios-Marcel commented 4 years ago

nah, the underlying framework :/

Dune-jr commented 4 years ago

Prefixing discord images with a \n would probably solve it as well for most setups

Bios-Marcel commented 4 years ago

i thought i had done that alrdy tbh

SkyLeite commented 4 years ago

I'd like to mention that Alacritty doesn't recognize links at all in cordless.

Bios-Marcel commented 4 years ago

Yo, while I haven't implemented the requested feature, you can now open files (NOT LINKS, but I am thinking about adding a second feature for that) via selecting the message and hitting "o".

Titaniumtown commented 4 years ago

oooh, thanks for the tip @Bios-Marcel!