Bios-Marcel / cordless

The Discord terminal client you never knew you wanted.
BSD 3-Clause "New" or "Revised" License
1.64k stars 140 forks source link

It should be possible to click a link, no matter if the terminal supports it natievly or not #92

Closed Bios-Marcel closed 4 years ago

Bios-Marcel commented 5 years ago

Since cordless can't show picture and such, stuff like downloading files, viewing pictures and whatnot, works via opening a link. I myself use a vte-based terminal, therefore I can click anything that follows the pattern https?://.+ (or so). However, some other terminals don't support this, which makes it very annoying to use cordless on those terminals.

aaronjanse commented 5 years ago

Even terminals that natively support URLs don't necessarily support URLs that wrap across lines within the message/chat window (as happens very often for Discord image URLs)

Bios-Marcel commented 5 years ago

Yup, true. Check the configfile, I added a local linkdhortener for that, it usually helps, even though it sometimes causes wrapping too.

aaronjanse commented 5 years ago

Ooh, thanks. I'll take a look!

viewing pictures and whatnot

Side note that while this is technically possible, I agree that it rarely works well (I personally prefer the link approach)

Bios-Marcel commented 5 years ago

Wdym?

aaronjanse commented 5 years ago

https://github.com/dylanaraps/neofetch/wiki/Images-in-the-terminal

The only terminal where I've gotten it to work reliably is xterm

Bios-Marcel commented 5 years ago

I recommend termite.

aaronjanse commented 5 years ago

I recommend termite.

I'll take a look :+1:

indeedwatson commented 4 years ago

Out of curiosity, is showing images downright impossible? Too complicated? I've used https://github.com/seebye/ueberzug and w3m for displaying images in ranger with termite, but I'm guessing scrolling complicates things?

Bios-Marcel commented 4 years ago

cba, there's no standard, it's hacky, wrong and not crossplatform

indeedwatson commented 4 years ago

gotcha

Bios-Marcel commented 4 years ago

Close in favor of #226