BipadTaranMahato / slideshow

Automatically exported from code.google.com/p/slideshow
0 stars 0 forks source link

Centering doesn't work on IE6 #11

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
A slideshow with images of varying size doesn't center images correctly if
the "resize" option is set to false.  Line 180 of version 46 of
slideshow.js is the culprit.  It appears that on IE (6.0 anyway), setting
the height and width to auto doesn't result in setting the height and width
attributes of the image until the image is shown.  I used a set of 7 images
with the corresponding height and width:
200 x 300
200 x 300
200 x 300
240 x 320
214 x 320
240 x 320
200 x 300

Inserting "window.status = this.image.height+", "+this.image.width;" at
line 182 of slideshow.js yielded the following output for the first time
through the set of images:
200, 300
200, 300
200, 300
200, 300
240, 320
240, 320

A possible fix is to set the height and width attributes (on line 180) to
this.preloader.height and this.preloader.width respectively.  This worked
on IE6.0 and Firefox 2.0.0.14.

Original issue reported on code.google.com by ourcarqu...@cox.net on 22 May 2008 at 7:52

GoogleCodeExporter commented 9 years ago

Original comment by aeron.gl...@gmail.com on 12 Jun 2008 at 10:39

GoogleCodeExporter commented 9 years ago
Should be fixed in SVN - thank you!

Original comment by aeron.gl...@gmail.com on 16 Jun 2008 at 12:48