Overlap option leaves the previous image displayed behind the current image

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Create images of unequal size to use in the slideshow.
2. Set the resize option to false.
3. Use the default value for overlap (true)

What is the expected output? What do you see instead?
A larger image that was being viewed before a smaller image cannot be seen
behind the smaller image.

The larger image is seen behind the smaller image.

What version of the product are you using? On what operating system?
SVN version 50 of slideshow.js

Please provide any additional information below.

Unless I'm misinterpreting what overlap should do, I would think that the
previous image would transition to its "hidden" state at the same time the
next image is transitioning to its "shown" state.  I'd think the code would
look something like:

    if (fast) {
            img.get('morph').set(hidden);
        this.image.get('morph').cancel().set(visible);          
    } else {
        if (this.options.overlap){  
        img.get('morph').start(hidden);
        this.image.get('morph').set(hidden).start(visible);
        } 
        else {
        var fn = function(hidden, visible){
            this.image.get('morph').set(hidden).start(visible);
            }.pass([hidden, visible], this);
        var hidden = this.classes.get('images', ((this.direction == 'left') ?
'prev' : 'next'));
            img.get('morph').set(visible).start(hidden).chain(fn);
        }
    }

Original issue reported on code.google.com by ourcarqu...@cox.net on 27 May 2008 at 6:49

[GoogleCodeExporter]

This has been fixed in the source (earlier reported as issue 3). I will be 
preparing a new download this weekend 
with the fix included.

Original comment by aeron.gl...@gmail.com on 28 May 2008 at 9:55

• Changed state: Fixed

[GoogleCodeExporter]

I'm working with the latest (revision 50 of slideshow.js)  The fix included 
still
leaves the larger image behind the smaller image if overlap is true (and images 
are
not resized).  If the intent of overlap is to keep the previous image shown, 
then
there is no bug in the code.  I presumed the intent of overlap, if "fast" is 
false,
was to transition the previously showing image to hidden while transitioning 
the next
image to shown.  If 
"fast" is true, I would expect the previous image to immediately be hidden and 
the
next image to immediately be shown.  It doesn't seem very useful that the 
previous
(larger) image would show up around the edges of a non-resized, centered, 
smaller image.

Original comment by ourcarqu...@cox.net on 29 May 2008 at 1:33

[GoogleCodeExporter]

Original comment by aeron.gl...@gmail.com on 29 May 2008 at 1:56

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by aeron.gl...@gmail.com on 12 Jun 2008 at 10:40

[GoogleCodeExporter]

This has now been fixed in SVN.

Original comment by aeron.gl...@gmail.com on 14 Jun 2008 at 4:57

• Changed state: Fixed