BipadTaranMahato / slideshow

Automatically exported from code.google.com/p/slideshow
0 stars 0 forks source link

HTML data doesn't use full image srcs or attached thumbnails #33

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I found two parts of slideshow that don't really make sense when using HTML for 
the data section 
(e.g. data is null).

1 - the path of slide image src's still use the hu: option for image paths.  
You should just read and 
use the full image src, since it's already defined in HTML

2 - the thumbnails in the HTML aren't actually parsed.  The image srcs from the 
slideshow-images 
section are still manipulated in with the replace: option, instead of just 
reading the thumbnail 
images from HTML.  That seems wrong.

I've attached my "patch" - really, just a diff, since I'm using git now.  Let 
me know if you guys start 
using Git/GitHub, and I'll make it a real patch.

Original issue reported on code.google.com by m3mo...@gmail.com on 17 Jul 2008 at 5:24

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks! I will definitely be incorporating this!

Original comment by aeron.gl...@gmail.com on 17 Jul 2008 at 5:46

GoogleCodeExporter commented 9 years ago
Thanks! This has been incorporated in SVN.

Original comment by aeron.gl...@gmail.com on 19 Jul 2008 at 9:05