Birch-san / arm-editor-launcher

M1 macOS Launcher for Live2D Cubism Editor
11 stars 0 forks source link

install-jogl.sh fix (replace w/ new zulu version - readme & script) #5

Closed quangmng closed 1 year ago

quangmng commented 2 years ago

There is a version of zulu available (this version on your readme & script does not exist?)

image Screen Shot 2022-05-24 at 19 08 37

No wonder why my artifacts were not installed properly...

Birch-san commented 2 years ago

the help text prints an Example invocation.
I can't know what JDK version you downloaded or where you extracted it to. You should download the latest available.
what would you suggest I write there instead? it's a moving target

quangmng commented 2 years ago

Firstly, what do you mean by "the help text"? (probs the comment part when command ran incorrectly/missing args.) Secondly, when you provide a placeholder, showing the path of zulu, don't put the part I highlighted earlier in my screenshot above in your Readme.md because that will confuse people.

image

Just do "latest-zulu-version" or something similar, up to you.

P.s.: Did I miss something here as well?

image
Birch-san commented 2 years ago

what do you mean by "the help text"?

the function print_help you included in your screenshot.

image

when you provide a placeholder, showing the path of zulu, don't put the part I highlighted earlier in my screenshot above in your Readme.md because that will confuse people

I've now changed the README to recommend renaming the folder so that the examples have a common standard filepath to work against.
I've also updated every JAVA_HOME example to explain that the folder path is indicative only.

Did I miss something here as well?

ah, you didn't miss anything. looks like it doesn't work with an empty Maven registry.

I've pushed a change to make it work better with clean install. I've also updated launcher.sh to work with the new license bridge server.

quangmng commented 2 years ago

Alright, I've used your new update and compiled the launcher. The maven install & jogl worked until this happened... (Ran both configurations. 1st one as-is, i.e. BridgeServer x86_64 and Unofficial Launcher aarch64). image

Birch-san commented 2 years ago

ah, yeah, license-bridge-server is special because it needs to be built & run with an entirely different JDK:

image

you'll need to download JDK8 (you can grab from the same Azul download page), and configure just license-bridge-server to be built with it.
_for building license-bridge-server, you can technically use native aarch64 JDK8, but best to download x8664 JDK8 if you want to be able to run any run configurations related to license-bridge-server.

all other projects can be built with the Project JDK (aarch64 FX JDK17).

image

this change escaped because it's not something that I can share via version control (it's local IntelliJ workspace config).

Birch-san commented 2 years ago

you may find it helpful uncheck "Use compiler from module target SDK" in settings:

image

otherwise, you'll find that license-bridge-server's Module SDK gets reset to the Project SDK every time you do a Maven Import.

quangmng commented 2 years ago

Thanks for the fix, L2D is launched w/ the licence server running now. Also just a quick question, will an activated L2D license work or it will default to a trial license?

Birch-san commented 2 years ago

brilliant! glad it's working. In theory an activated L2D license could work, but I haven't tried it.