search

BirdAPI / yamaha-network-receivers

EventGhost plugin to control Yamaha RX-V network receivers
47 stars 9 forks source link

Create Next / Previous Source Input functions #3

Closed BirdAPI closed 11 years ago

BirdAPI commented 11 years ago

There is already code that is supposed to do this, but i dont think it works. If anything you can create a list of sources in the globals.py and check the current index and then change to next index.

Should probably have the ability to wrap when user gets to the beginning or end.

BirdAPI commented 11 years ago

Maybe have a configure page that just has a bunch of checkboxes and it lets you choose which of the available sources you want to toggle between (for users who dont use the sources or their reciever doesnt support them).

Dragon470 commented 11 years ago

I have thought about checking for "feature availability" right from the plugin load. This could be done to exclude the inputs that are not even there.

BirdAPI commented 11 years ago

I have started working on a function that loads checkboxes automatically for inputs in a list (currently globals.ALL_SOURCES), but once i finish that it could be changed to only load from a list of available sources.

My current thinking with the checkboxes is that the user may only want to cycle through the hdmi, or maybe only through ones that actually have something plugged in.

Does the feature availability let you know if something is plugged in, or only if the receiver supports it?

BirdAPI commented 11 years ago

I just committed the NextInput and PreviousInput action classes. Currently these will let you select out of a giant list of sources that you may not even have. There is a bug where if you include a source that you do not have it will get "stuck" on your current input.

Dragon470 commented 11 years ago

I just started looking at the feature availability. I can test with a few inputs.

Otherwise am just now adding the SetSleep. I don't like that there is no countdown clock for the sleep at this time. But I am committing it now.

On Fri, Sep 27, 2013 at 8:12 PM, BirdAPI notifications@github.com wrote:

I just committed the NextInput and PreviousInput action classes. Currently these will let you select out of a giant list of sources that you may not even have. There is a bug where if you include a source that you do not have it will get "stuck" on your current input.

— Reply to this email directly or view it on GitHubhttps://github.com/BirdAPI/yamaha-network-receivers/issues/3#issuecomment-25287380 .

Jason Kloepping

BirdAPI commented 11 years ago

My code now will attempt to detect if a change was not made successfully and skip to the next one in the list. The feature availability isn't required for it to work properly (since you can't get stuck anymore), but it would definitely help reduce some of the clutter by getting rid of the unsupported checkboxes.

Dragon470 commented 11 years ago

I just committed an action to check for availability of zones and inputs. It just prints the valid info out for now. It works for mine rx-v671. The output is: 0 not available 1 available not connected (but available) HDMI(X) available etc(x) available

or

error NOT available

If it works on your models, It can be used to filter out unavailable sources and zones as options.

On Sat, Sep 28, 2013 at 12:03 AM, BirdAPI notifications@github.com wrote:

My code now will attempt to detect if a change was not made successfully and skip to the next one in the list. The feature availability isn't required for it to work properly (since you can't get stuck anymore), but it would definitely help reduce some of the clutter by getting rid of the unsupported checkboxes.

— Reply to this email directly or view it on GitHubhttps://github.com/BirdAPI/yamaha-network-receivers/issues/3#issuecomment-25290721 .

Jason Kloepping

BirdAPI commented 11 years ago

This looks like its working for all of mine, except i did notice on my RX-V867 it has a MULTI CH input, but the code says it does not. Its most likely the xml name is different than what you used.

I don't like the fact that it has to query the receiver over the internet for each source. I think i can get it in one transmit.

Dragon470 commented 11 years ago

You can and should do it in one, but this was just a proof of concept.

On Tue, Oct 1, 2013 at 6:31 PM, BirdAPI notifications@github.com wrote:

This looks like its working for all of mine, except i did notice on my RX-V867 it has a MULTI CH input, but the code says it does not. Its most likely the xml name is different than what you used.

I don't like the fact that it has to query the receiver over the internet for each source. I think i can get it in one transmit.

— Reply to this email directly or view it on GitHubhttps://github.com/BirdAPI/yamaha-network-receivers/issues/3#issuecomment-25501696 .

Jason Kloepping

BirdAPI commented 11 years ago

The correct value for multi channel is MULTI_CH, i just tested it on my rx-v867 and it picks it up

BirdAPI commented 11 years ago

We probably also need a mapping for feature availability name to source input name, because to check for availability you need to use HDMI_1, but to change input to it, you use HDMI1

BirdAPI commented 11 years ago

I just committed the finished code to do this. I am marking this as closed.