search

BirdsCanada / NatureCountsAPI

NatureCountsAPI
0 stars 1 forks source link

list_collections behaviour with no token #25

Open steffilazerte opened 5 years ago

steffilazerte commented 5 years ago

When I access list_collections without a token, some of the collections (e.g., ABATLAS1 and ABATLAS2 among others) return yes in the access column.

Since users must have a token to download the data, this is a bit misleading, and I suspect a hold over from when users weren't required to actually have a token to download the public collections (?).

pmorrill commented 5 years ago

Good point. These are collections that have public access, but since we require a token to get_data, this information is not very valuable. Probably, if there is no token in the request, we should not include the 'access' field in the response?

steffilazerte commented 5 years ago

Either that or no (as in no access). I can easily omit the field in the R client, but it might be better (for consistency) to do so in the API.