BirdsCanada / naturecounts

R package to access data from the NatureCounts platform by Bird Studies Canada
https://birdscanada.github.io/naturecounts/
13 stars 4 forks source link

IBA filter not respected #21

Closed steffilazerte closed 1 year ago

steffilazerte commented 1 year ago

Hi @denislepage,

Are the naturecounts API filters still working as expected?

My tests show an issue with the IBA filter (at least). This query, is returning all records, not just for IBA AB001...

Entry point: /api/data/list_collections Query: info=nc_test&token=XXXX&filter={"bmdeVersion":"BMDE2.00-min","iba":["IBA.AB001"]}

denislepage commented 1 year ago

I just posted a fix in sandbox, @steffilazerte could you kindly test it? We recently made some changes that created this issue.

steffilazerte commented 1 year ago

I tested, looks good to me, doesn't work on main does work on sandbox

denislepage commented 1 year ago

Perfect. That is the expected behaviour. We'll deploy shortly to live.

steffilazerte commented 1 year ago

@denislepage, @cjardine-bsc are we going live with this soon?

cjardine-bsc commented 1 year ago

This should (I think) have already been pushed. Is it not working on live?

steffilazerte commented 1 year ago

You're right, awesome, I'll finish the release today 🎉