Removes a bunch of hard coded values and fixes two more issues

BirdyF / rw_tcx

Dart package to read or write TCX files

Other

7 stars 3 forks source link

Removes a bunch of hard coded values and fixes two more issues #4

Closed MrCsabaToth closed 5 months ago

MrCsabaToth commented 3 years ago

It'd be good to write a test where we construct a random filled TCXInfo and then check back if those random values persist into the file instead of the previous hard-coded one. I'd need to look up how to mock the file writing and stuff.

Besides the substitutions (the string interpolations) I also performed a standard Flutter format as a minimum I can do for code quality.

MrCsabaToth commented 3 years ago

Ok. so the PR now tries to fix the Cadence write support as well. Cadence is a positive integer, byte.

BirdyF commented 5 months ago

@MrCsabaToth thanks. Sorry for the ...delay!! But I am back.