search

BirjuVachhani / adaptive_theme

Easiest way to add support for light and dark theme in your flutter app.
https://pub.dev/packages/adaptive_theme
Apache License 2.0
464 stars 37 forks source link

:bug: changed getter darkTheme to always return darkTheme and added getter lightTheme #17

Closed bernhardfrenking closed 3 years ago

bernhardfrenking commented 3 years ago

Description of the Change

adding an additional getter lightTheme and changing the getter darkTheme to always returning the dark theme instead of returning the current theme.

Alternate Designs

instead of the additional getter, the getter theme could alway return the lightTheme

Why Should This Be In Core?

mode independend getter for the modes are necesseray, if you need it for example in a theme settings screen

Benefits

usability improved in case of theme setting screens

Possible Drawbacks

not known

Verification Process

What process did you follow to verify that your change has the desired effects?

Applicable Issues

not known

BirjuVachhani commented 3 years ago

@bernhardfrenking Thanks for the PR. It will be available in the next release. 😊