BirjuVachhani / locus-android

An Awesome Kotlin Location library to retrieve location merely in 3 lines of code
https://birju.dev/posts/retrieve-location-in-just-3-lines-android/
Apache License 2.0
358 stars 40 forks source link

Support Huawei HMS Location Kit #81

Closed kosratdev closed 1 year ago

kosratdev commented 1 year ago

Is your feature request related to a problem? Please describe. As you know, Google Play Service has been banned in Huawei devices since 2019. After that, Huawei created its own library to provide location services. It could be a great feature if there is a library to support both services at the same time.

Describe the solution you'd like Support Google Play Service and Huawei HMS Location in the same library.

Describe alternatives you've considered

Additional context

mohamedagamy commented 1 year ago

Yes it will be great to provide both HMS , GMS.

mohamedagamy commented 1 year ago

I've migrated the source code to HMS I'll try to share it here soon. Check my repo for HMS support https://github.com/mohamedagamy/locus-android.

kosratdev commented 1 year ago

Dear @mohamedagamy thanks for your efforts and @BirjuVachhani please can you check the provided repo and make it possible to support GMS and HMS in one library?

mohamedagamy commented 1 year ago

HMS Toolkit can help to migrate Also you can check my repo for the migration steps.

BirjuVachhani commented 1 year ago

@mohamedagamy Thank you for your efforts. I am not familiar with HMS Toolkit. Would you mind opening a PR with your changes rather than a separate repo? It would really help me understand the changes and review your work. Thanks!

Abdullqadir commented 1 year ago

Hello @BirjuVachhani,

I made a PR for Huawei support please check it. I have faced some difficulties while trying to register the sample project in the Huawei App Gallery saying the package name is already registered.

kosratdev commented 1 year ago

Hello @BirjuVachhani

Please check the PR.

kosratdev commented 1 year ago

Hello @BirjuVachhani,

I would like to inquire about the status of the issue. Has there been any progress since @Abdullqadir submitted a PR to resolve it?

BirjuVachhani commented 1 year ago

@kosratdev I'll try to review this as soon as I have some bandwidth. Thanks!

kosratdev commented 1 year ago

Hi @BirjuVachhani, Is there any updates regarding the PR?

BirjuVachhani commented 1 year ago

This is now available in v5.0.0. 🎉