BirjuVachhani / locus-android

An Awesome Kotlin Location library to retrieve location merely in 3 lines of code
https://birju.dev/posts/retrieve-location-in-just-3-lines-android/
Apache License 2.0
358 stars 40 forks source link

Feature/huawei support #87

Closed Abdullqadir closed 1 year ago

Abdullqadir commented 1 year ago

Requirements

Description of the Change

Added Huawei support as mentioned in this issue #81.

Alternate Designs

Why Should This Be In Core?

To support those devices that do not have google play service.

Benefits

Huawei Support

Possible Drawbacks

Verification Process

Applicable Issues

Abdullqadir commented 1 year ago

I have faced some difficulties while trying to register the sample project in the Huawei App Gallery saying the package name is already registered.

Abdullqadir commented 1 year ago

@BirjuVachhani Any Updates?

BirjuVachhani commented 1 year ago

Hey @Abdullqadir Thank you for opening this PR! I'll review it as soon as I have some bandwidth!

BirjuVachhani commented 1 year ago

I have faced some difficulties while trying to register the sample project in the Huawei App Gallery saying the package name is already registered.

@Abdullqadir Is this necessary to run the example app on Huawei devices?

Abdullqadir commented 1 year ago

I have faced some difficulties while trying to register the sample project in the Huawei App Gallery saying the package name is already registered.

@Abdullqadir Is this necessary to run the example app on Huawei devices?

Yes, it is.

BirjuVachhani commented 1 year ago

I have faced some difficulties while trying to register the sample project in the Huawei App Gallery saying the package name is already registered.

@Abdullqadir Is this necessary to run the example app on Huawei devices?

Yes, it is.

Interesting! I just tested a debug build on a real Huawei device using BrowserStack and it works with your current config on the PR! Idk if removing them would make it not work or something!

To me, it seems that you should be able to run any debug builds on Huawei devices w/o doing this config. Seems like it is only required if you wanna publish to their app store or something!

Abdullqadir commented 1 year ago

I have faced some difficulties while trying to register the sample project in the Huawei App Gallery saying the package name is already registered.

@Abdullqadir Is this necessary to run the example app on Huawei devices?

Yes, it is.

Interesting! I just tested a debug build on a real Huawei device using BrowserStack and it works with your current config on the PR! Idk if removing them would make it not work or something!

To me, it seems that you should be able to run any debug builds on Huawei devices w/o doing this config. Seems like it is only required if you wanna publish to their app store or something!

That is great. If it works then we shall proceed. I will resolve your comments to finalize everything. Regarding the testing, I have only tested the sample application. I will test it again tomorrow.

Abdullqadir commented 1 year ago

Hello @BirjuVachhani, I have made some updates and answered your questions please check them. If you have any concerns or anything you want to change please let me know.

Abdullqadir commented 1 year ago

Regarding testing, I have tested everything it works fine. I have only faced one issue which was:

After installing the application for the first time if we press the Single Update button before the Start update button we were getting back null on the success listener on the fused location provider.

I have fixed this issue in this commit ab71367.

Abdullqadir commented 1 year ago

Hello @BirjuVachhani, I hope that you are doing well. I have fixed the issue regarding the user's configurations on Location Request I have updated it and tested it on Huawei and Google. works fine. Please let me know if you have any concerns.

BirjuVachhani commented 1 year ago

@Abdullqadir Thanks for the update. I'll review it.

BirjuVachhani commented 1 year ago

@Abdullqadir Nice job on the PR, specially on LocationRequestConfiguration.

Abdullqadir commented 1 year ago

@Abdullqadir Nice job on the PR, specially on LocationRequestConfiguration.

Thanks, @BirjuVachhani, I will resolve everything ASAP.

Abdullqadir commented 1 year ago

Hello @BirjuVachhani, I have resolved all the comments, Please let me know if there is anything else to update.

BirjuVachhani commented 1 year ago

Thank you @Abdullqadir for your contributions. 🎉

I'll try to release this today!

Abdullqadir commented 1 year ago

I'll try to release this toda

I'm glad to hear that. Thanks to you for your reviews @BirjuVachhani