zemcov-surf commented 2 years ago

Description of the Change

In the previous pull request to add the values parameter, I forgot to call assenName formatting when adding their to the List values. Because of this, an error appears when generating such pictures. In this query I corrected my mistake

Alternate Designs

Why Should This Be In Core?

My previous PR ( https://github.com/BirjuVachhani/spider/pull/39 ) is merged to main and available on pub.dev now. But it have bug and if someone tries use this with snake_case named assets he get an error

Benefits

Possible Drawbacks

I fix my previous mistake

Verification Process

Now I global activated my local brunch and generated dart classes with values property. The problem is gone

Applicable Issues

codecov-commenter commented 2 years ago

Codecov Report

Merging #41 (2f909f5) into main (22c1896) will increase coverage by 0.15%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   86.27%   86.42%   +0.15%     
==========================================
  Files          11       11              
  Lines         357      361       +4     
==========================================
+ Hits          308      312       +4     
  Misses         49       49

Impacted Files	Coverage Δ
lib/src/dart_class_generator.dart	`94.35% <100.00%> (+0.18%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22c1896...2f909f5. Read the comment docs.

BirjuVachhani commented 2 years ago

@zemcov-surf Thank you for finding and fixing this. PR looks good to me except code formatting which I'll take care of.