search

BirjuVachhani / spider

A small dart library to generate Assets dart code from assets folder.
https://spider.birju.dev/
Apache License 2.0
190 stars 20 forks source link

Feature/asset classes docs #56

Closed Sanlovty closed 2 years ago

Sanlovty commented 2 years ago

Description of the Change

Start asset-class file generation with ignore_rules

Benefits

Follow linter rules ,no more warnings

Verification Process

Generate asset-classes and analyze with linter

Applicable Issues

Closes #55

Sanlovty commented 2 years ago

Update: I can make this solution more interesting - we can allow user to pass the set of rules ignore_rules: [first-rule, second-rule, third-rule] instead of hardcoding it ( sometimes user can set linter rules that include member sorting or etc, so we will prevent this)

codecov-commenter commented 2 years ago

Codecov Report

Merging #56 (09b4b4c) into main (4e4cc97) will increase coverage by 2.36%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   68.30%   70.67%   +2.36%     
==========================================
  Files          13       15       +2     
  Lines         489      566      +77     
==========================================
+ Hits          334      400      +66     
- Misses        155      166      +11
Impacted Files Coverage Δ
lib/src/utils.dart 78.90% <ø> (+1.71%) :arrow_up:
lib/src/data/export_template.dart 80.00% <100.00%> (+5.00%) :arrow_up:
lib/src/dart_class_generator.dart 91.87% <0.00%> (-2.57%) :arrow_down:
lib/src/constants.dart 50.00% <0.00%> (ø)
lib/src/asset_subgroup.dart 81.81% <0.00%> (ø)
lib/src/subgroup_property.dart 100.00% <0.00%> (ø)
lib/src/asset_group.dart 83.87% <0.00%> (+0.53%) :arrow_up:
lib/spider.dart 40.62% <0.00%> (+0.94%) :arrow_up:
lib/src/data/test_template.dart 80.00% <0.00%> (+13.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 537e608...09b4b4c. Read the comment docs.