US1 – List of Outivities

BirkBee / outivities-app

https://outivities-app.vercel.app

6 stars 4 forks source link

US1 – List of Outivities #5

Closed Julia-Pickel closed 10 months ago

Julia-Pickel commented 10 months ago

In the 1st User Story we did following tasks:

Create feature-branch
Create example data with 6 Outivities
Create and display headline with the title "All Outivities"
Create Card Component
Create List Component
Render Cards in List Component
Render List in Homepage
Add error handling
and we added some styling

We are looking forward to getting some feedback on that. – Thanks in advance ! 🙌

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
outivities-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 16, 2023 11:10am

Julia-Pickel commented 10 months ago

Hey @JessicaLoers, thank you for your recommendations !!

We updated the User Story 1 as follows:

removed try... catch
removed double gap of ul named StyledOutivityCardContainer
html semantic:
- added an <article> framing our ul
- added a <main> framing our article
- added a <Head> for the HomePage

lennart-kaminsky commented 10 months ago

Hej @Julia-Pickel, @BirkBee , @ykolomytseva and @Philipp-Hess!

It's really cool and interesting to see your start into this project. Really nice way to design, we also learned a lot from reading your code.

We don't really have anything to add to @JessicaLoers review - it seems that you just have to drop the return with the error handling and you're good to go!

Julia-Pickel commented 10 months ago

Hi @lennart-kaminsky !

Thank you for your feedback and kind words 🙌 We removed the error handling :)

lennart-kaminsky commented 10 months ago

LGTM