search

Birkbjo / OctoPrint-Themeify

Beautiful themes for OctoPrint
94 stars 34 forks source link

$(window).on('resize') breaks in Firefox #48

Open FormerLurker opened 5 years ago

FormerLurker commented 5 years ago

I've been struggling with bootstrap modal dialog sizing for the last week or so, and had written it off as a mistake on my part or some kind of problem with Firefox (works perfectly in chrome). However, after more testing I discovered that resize events aren't being triggered via Jquery at all anywhere. I created a fiddle to test out $(window).on('resize') and it seemed to work fine in firefox, but not within Octoprint. However, I could also see that window.addEventListener DID correctly attach to and trigger the resize event! Very strange. Eventually I booted in safe mode and things started to resize correctly (Octoprint settings modal is the easiest one to check). After a bit of fiddling and a lot of rebooting I determined that the resize issue goes away when themeify is disabled (completely disabled after a restart of Octoprint, not simply disabled within the themeify settings). I'll do a bit of digging and see if I can find the exact line that's causing the problem, but if you have any ideas and can point me in the right direction, that would be great!

Also, I LOVE this plugin. Bright pages seer my eyes after a long day of programming, and I love being able to make things dark. You have created an incredibly useful and simple to use plugin, and I have really enjoyed it. I initially installed it just to fix (some of) the (horrible) css mistakes within my plugin so that themes would be applied correctly, and now it's on my must have plugin list. Thank you so much!

Birkbjo commented 4 years ago

Sorry for the late reply. What theme did you use? I'm not able to reproduce this.

FormerLurker commented 4 years ago

Thanks for getting back with me! I will test it out again after work to make sure there is still a problem before we go any further. I remember doing some work on this a long while ago, but can't remember what I came up with, so maybe it is a non-issue.