search

BirminghamConservatoire / JohannesTinctoris

Editing and rendering text and music notation for online edition of music treatises
7 stars 4 forks source link

Editorially suppressed clef insertions not reflected properly in variant popups #15

Closed goursaud closed 3 years ago

goursaud commented 4 years ago

Editorially suppressed clef insertions in sources are not reflected properly in variant popups that immediately follow the insertion. The clef configuration is, however, displayed correctly for the variants in rest placement in the third yellow popup.

<piece: {mensural: void}, {staf: 5, black}> <part: 1 > {clef: C8} Bd {var= (ins.) "{clef: C6}" CS15} {var="mc. sb" Br3 : "Sc" CS15} {var="Pm13" Br3 : "Pm9" CS15} {var= (ins.) "{clef: C8}" CS15} </part> </piece>

image

The problem does not occur if a note is arbitrarily placed between the inserted clef and the opening variant tag.

annplaksin commented 4 years ago

It seems like there is a problem in recognising the clef change in the sucsessive variants. Obviously it works with inserting a positive space...

<piece: {mensural: void}, {staf: 5, black}> <part: 1 > {clef: C8} Bd {var= (ins.) "{clef: C6}" CS15} 
[-]{var="mc. sb" Br3 : "Sc" CS15} {var="Pm13" Br3 : "Pm9" CS15} {var= (ins.) "{clef: C8}" CS15} 
</part> </piece>

grafik

annplaksin commented 3 years ago

Most probably I fixed the problem. I just realized, that the default clefs aren't repeated in variable popups on purpose. So, is this okay for now or would it be better to draw default clefs in variant popups? And follow up question, how urgent would that be?

grafik