BirminghamConservatoire / JohannesTinctoris

Editing and rendering text and music notation for online edition of music treatises
7 stars 4 forks source link

Insertions in ligatures won't work #19

Open annplaksin opened 4 years ago

annplaksin commented 4 years ago

There are problems with some things, that show up within ligatures and with insertions inside ligatures:

Test insertions within ligatures
<piece: {mensural: void}, {staf: 5, black}> 
<part: 1 >
<label>Inserted stuff</label>a
{clef: C8} Bd md{var=(ins.) "*" A} | Bd md{var=(ins.) "?" A} | Bd md{var=(ins.) "." A} | Bd {var=(ins.) "b9" A} md | Bd {var=(ins.) "{clef: C10}" A} md |
</part>
<part: 2 >
{staf: 5, black}
<label>Stuff in ligatures: Accidentals won't work - Clefs in ligatures break stuff </label>
{clef: C8}
<lig>Bd* Ba</lig> <lig><obl>Bd*11 Ba</obl></lig> |
<lig>Bd? Ba</lig> <lig><obl>Bd?11 Ba</obl></lig> |
<lig>Bd. Ba</lig> <lig><obl>Bd. Ba</obl></lig> |
<lig>Bd b9 Ba</lig> <lig><obl>Bd b9 Ba</obl></lig> |
<lig>Bd Ba</lig> {clef: C8} <lig><obl>Bd Ba</obl></lig>  |
</part>
<part: 3 >
{staf: 5, black}
<label>Insertion in ligatures -- are bad!</label>
{clef: C8}
<lig>Bd{var=(ins.) "*" A} Ba</lig> <lig><obl>Bd Ba</obl></lig> |
<lig>Bd{var=(ins.) "?" A} Ba</lig> <lig><obl>Bd Ba</obl></lig> |
<lig>Bd{var=(ins.) "." A} Ba</lig> <lig><obl>Bd. Ba</obl></lig> |
</part>
</piece>
annplaksin commented 4 years ago

Note: Inserted SG in Oblique in Tenor "Qui regnas in celestibus"... this is important!

JohannesTinctoris commented 4 years ago

It's looking good in Safari right now...

-jjd


Dr Jeffrey J. Dean PI, AHRC Mensural Notation Project 4 Chandos Road Royal Birmingham Conservatoire Chorlton-cum-Hardy tel: +44(0)161 861 7542 Manchester M21 0ST fax: +44(0)161 861 7543 England www.earlymusictheory.org/Tinctoris/ jeffrey.dean@bcu.ac.uk jeffrey.dean@stingrayoffice.com

On 13 Nov 2020, at 17:26, Anna Plaksin notifications@github.com wrote:

Note: Inserted SG in Oblique in Tenor "Qui regnas in celestibus"... this is important!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

annplaksin commented 4 years ago

It might be broken in a short while... I just pushed the custos and clef stuff... (but this wouldn't make any sense)

annplaksin commented 4 years ago

Okay, "Qui regnas in celestibus" was another bug only happening in Obliques. Insertions still don't work...

annplaksin commented 4 years ago

Okay... inserted SC in ligatures and obliques work.

Do we need to handle inserted fermatas, accidentals and dots for now? If not, we can reduce the priority for this issue. As far as I see, in Liber de Arte contrapuncti, this isn't the case, but I'd rather like to double check.

JohannesTinctoris commented 4 years ago

Brilliant timing! I was just about to confirm that everything looks good now, except for one tiny detail: in II.xxx.ex1, the second SC, beneath the breve, is placed too high, so it collides with the note.

I haven't noticed any faults with the other signs in De arte contrapuncti. I think these are things that crop up in the practical pieces; we can deal with them next year...

Best, Jeff


Dr Jeffrey J. Dean PI, AHRC Mensural Notation Project 4 Chandos Road Royal Birmingham Conservatoire Chorlton-cum-Hardy tel: +44(0)161 861 7542 Manchester M21 0ST fax: +44(0)161 861 7543 England www.earlymusictheory.org/Tinctoris/ jeffrey.dean@bcu.ac.uk jeffrey.dean@stingrayoffice.com

On 20 Nov 2020, at 15:42, Anna Plaksin notifications@github.com wrote:

Okay... inserted SC in ligatures and obliques work.

Do we need to handle inserted fermatas, accidentals and dots for now? If not, we can reduce the priority for this issue. As far as I see, in Liber de Arte contrapuncti, this isn't the case, but I'd rather like to double check.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

annplaksin commented 4 years ago

You should be able to change the position of the SC manually...

JohannesTinctoris commented 4 years ago

Done...


Dr Jeffrey J. Dean PI, AHRC Mensural Notation Project 4 Chandos Road Royal Birmingham Conservatoire Chorlton-cum-Hardy tel: +44(0)161 861 7542 Manchester M21 0ST fax: +44(0)161 861 7543 England www.earlymusictheory.org/Tinctoris/ jeffrey.dean@bcu.ac.uk jeffrey.dean@stingrayoffice.com

On 20 Nov 2020, at 15:49, Anna Plaksin notifications@github.com wrote:

You should be able to change the position of the SC manually...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

annplaksin commented 4 years ago

Wonderful! Then I'll reduce the priority to "future problems"...