search

BirminghamConservatoire / JohannesTinctoris

Editing and rendering text and music notation for online edition of music treatises
7 stars 4 forks source link

Ledger lines within variants #3

Open goursaud opened 4 years ago

goursaud commented 4 years ago

Variants seem to nullify ledger lines:

<pars> {clef: C4} {solm: 0} {mens: "C9" edP : "c13" Car edF edB : (om.) CS49 : (deest) Luc} Lg <text>Benedi{var=(ins.) "ctus" CS49 : "c-" Car}-</text> Sbb. mcc <lig>Sdd See.</lig> mdd {var="<lig><obl>Scc Sbb</obl> Bdd</lig>" CS49 : "<lig>Scc Sbb Bdd</lig>" Car} <lig>Scc Sbb <obl>Baa Bg</obl></lig> {var=(ins.) "{staf: 5} {clef: C4} {solm: bbb}" CS49} Sdd. mcc Bcc Sbb <text>{var="ctus" (ed.) : (transp.) CS49 Car}</text> Bcc PS11 Scc <text>{var="qui" CS49 : (transp.) Car}</text> <lig><obl>Sbb Saa.</obl></lig> mg <lig>Sf <obl>Se Bd</obl></lig> Saa mbb mg <text>{var=(ins.) "venit" CS49}</text> {var="Sg. mf mf" CS49 edF edB edP : "Sg mf Sf" Car} me Sg. mf me <text>{var=(ins.) "tus" Car}</text> md Sd PS11 Sdd <text>ve -</text> Sbb <lig>Sg Scc.</lig> mdd See. {var=(ins.) "<ll: 1>bff</ll>" Car} mdd {var="<ll: 1>bff</ll>" (ed.) : (transp.) Car : (om.) CS49}> {var="<ll: 1><lig><obl>Sff See</obl></lig></ll>" CS49 edF edB : "<ll: 1>Sff See</ll>" Car} <lig>Scc Sdd.</lig> mcc mcc Sbb <text>nit</text> Ldd PB11 </pars>

Near the end of this I'd like to have a ledger line extending from before the minim dd to after the oblique ligature ff-ee, and in each of the variants from the inserted flat to the ligature, and to be inputting this in the simplest way manageable. I don't suppose this would work:

<ll: 1>{var=(ins.) "bff" Car} mdd {var="bff" (ed.) : (transp.) Car : (om.) CS49}> {var="<lig><obl>Sff See</obl></lig>" CS49 edF edB : "Sff See" Car}</ll>

annplaksin commented 4 years ago

Just a short remark... at least for me it would be helpful if examples would be provided as a minimal functioning example for the Workinput, e.g. like

<piece: {mensural: void}, {staf: 5, black}>
{clef: C4} {solm: 0} {mens: C9}  mdd See. {var=(ins.) "<ll: 1>bff</ll>" Car} mdd {var="<ll: 1>bff</ll>" (ed.) : (transp.) Car : (om.) CS49}> {var="<ll: 1><lig><obl>Sff See</obl></lig></ll>" CS49 edF edB : "<ll: 1>Sff See</ll>" Car} <lig>Scc Sdd.</lig> mcc mcc Sbb <text>nit</text> Ldd PB11
</piece>

Providing the intended element is in that case more important than reducing the amount of content. I hope this is okay with you. Thanks!

annplaksin commented 4 years ago

Just a note: It seems like the ledger line change has been applied by the parser, then it is a rendering issue

goursaud commented 4 years ago

I think, though I'm not 100% sure, that the following is a connected problem. Here, the ledger line is prevented from displaying with the second SGG when a variant directly follows it, even though the ledger line isn't actually involved in the variant at all:

<piece: {mensural: void}, {staf: 5, black}> {clef: F8} {solm: 0} {mens: C7} <ll:-1>SGG</ll> SA <ll:-1>SGG</ll> {var="Pm9" Br3 : (om.) CS15} </piece>

image

annplaksin commented 3 years ago

Ledger lines aren't displaying in the Contrapunctus of Alleluia 1 (II.xxii.ex2), if a variant or insertion occurs. See also the end of the Contratenor of Katerina sponsa Dei (II.xxviii.ex1). For some reason they're doing fine in Alleluia 2 (II.xxii.ex3) and Sancte Joannes Baptista (II.xxv.ex1).

grafik

grafik

annplaksin commented 3 years ago

Ledger lines inside variants, that end right with the end of the variant don't work because the support of ending classes at the end of variants isn't implemented yet. This is something, that will need quite some effort... this might be done after some easier fixes are done.

Ledger lines are now working well and consistently in the main music, but they're lost in the popups: grafik