search

BirthdayResearch / defichain-app

DeFi Blockchain desktop app for Windows, Linux and Mac.
https://defichain.com
MIT License
157 stars 57 forks source link

App is not showing any rewards #1014

Closed nico89-exp closed 3 years ago

nico89-exp commented 3 years ago

Actual behavior:

When switching to Transaciotns tag, checking "Include Rewards" doesn't show any rewards. Only transactions are shown. Also the export is not containing rewards.

Expected behavior:

Rewards and Commisions should be shown and also exported. This worked in 2.5.2

How to reproduce it (as minimally and precisely as possible):

cf. above

What are your environment parameters?

Anything else we need to know?

defichain-bot commented 3 years ago

@nico89-exp: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

In the meantime, you can:

  1. Checkout DeFiChain’s Github issue page to see if your issue has already been reported
  2. Submit any logs if you have them, this will greatly expedite the process for us.
  3. You can also join our Telegram or Reddit community channels.
Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/app/blob/master/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
nico89-exp commented 3 years ago

Tested also on Linux -> same issue

CLI with listaccount address command exports correctly.

izzycsy commented 3 years ago

Hi @nico89-exp , thanks for your feedback, could you kindly send your logs for investigation please? Thank you.

1 App log 2 Compress
izzycsy commented 3 years ago

Hi @nico89-exp , update v2.6.1 is out. 
Please read through the release notes before updating. This comment is to notify you about the update.

chk- commented 3 years ago

I am also affected, but not since the update to v2.6.0 or v2.6.1, but since I disbanded and reorganized my LM, utilising one rewards DFI address for each LM-pool.

izzycsy commented 3 years ago

Hi @chk- , rewards would be shown under the DFI tab; since rewards are given out in DFI. If your rewards are not shown after checking Include reward transactions, please take a screenshot & send your logs for investigation. Thank you.

Include reward tx
chk- commented 3 years ago

Hi @izzycsy, I can confirm that I checked the "Include reward transactions" checkbox.

I would suggest checking in the source code whether all DFI addresses are queried during the export and not just the initial / primary address. I don't have a setup for debugging right now, but I guess the part in DeFiCh/app/webapp/src/containers/TransactionsPage/service.tsx: 481 would be a good breakpoint.

chk- commented 3 years ago

Hi @izzycsy, in addition, I share my experiences as follows.

These steps reproduce the problem:

1.) Create a wallet with standard values ​​(1 DFI address @mydfi) 2.) Creation of an LM pool BTC-DFI (rewards to the address @mydfi) 3.) Creation of a LM pool ETH-DFI (rewards to the address @mydfi)

Result when exporting including rewards: All rewards available.

4.) Create 2 DFI addresses: @mydfibtc, @mydfieth 5.) Dissolve the two LM pools 6.) Creation of an LM pool BTC-DFI (rewards to the address @mydfibtc) 7.) Creation of a LM pool ETH-DFI (rewards to the address @mydfieth)

Result when exporting including rewards: No more new rewards available.

8.) Dissolve the two LM pools 6.) Creation of an LM pool BTC-DFI (rewards to the address @mydfi) 7.) Creation of a LM pool ETH-DFI (rewards to the address @mydfi)

Result when exporting including rewards: All rewards available.

Summary of the status: At first everything worked with just one DFI address. As soon as several DFI addresses were configured for the LM pools, the export function no longer fetched the new rewards, but all previously historical rewards were available. After the LM pools were set up again to the original DFI address, all rewards from all addresses were in the export again.

memzila commented 3 years ago

Thanks @chk- for this detailed analysis. This issue is open since several months. I have similar issues because i have startet with multiple addresses and have moved all to only one address. Long it was that i had not seen rewards since the move to one address. After some recent version it is the other way around. I don’t see rewards older than the move to one address.

izzycsy commented 3 years ago

Thanks @chk- @memzila , the team will look into the issue. Could you save and send your logs please, it'll help with the investigation. Thank you.

memzila commented 3 years ago

First the synching problems need to be fixed before i can normaly work with the wallet again. I have currently the other known issue with the very slow synching

izzycsy commented 3 years ago

Hi @chk- @memzila , update v2.6.2 is out. 
Please read through the release notes before updating. This comment is to notify you about the update.

memzila commented 3 years ago

Hi @chk- . Have you tested with newest version already? Probably they have fixed it finaly. At least i see older rewards now in the export than when i have all moved to one address.

chk- commented 3 years ago

Hi, everyone,

I just upgraded from v2.6.1 to v2.6.2. So far everything is going as usual. @izzycsy regarding the transmission of my logs, I have concerns about possibly disclosing personal data.

My current status is that I have reconfigured to only one DFI address and therefore cannot say whether v2.6.2 can solve the problem. I don't want to change that either. However, I assume that the problem can be reconstructed from my and other descriptions.

I hope this is okay with you.

The reason why I wanted to use several DFI addresses is to be able to display the rewards for each pool separately. (A must) When I discovered that this was already possible through the poolID in the data set, I no longer saw any reason for multiple DFI addresses. Otherwise it would also be possible to operate several wallets. What is the reason for having multiple addresses in the wallet? The question is not meant to be suggestive, but I ask for an answer in order to be able to build understanding.

izzycsy commented 3 years ago

Hi @chk- , thanks for sharing your experience, unfortunately we're unable to reproduce it, and in such cases the app logs will be useful for investigation. The app logs does not contain information with others can use, it's for the purpose of when a user faces an issue and we can further understand and try to resolve it. I understand that you've concerns sending it, so it's fine. The workaround would be as you mentioned 1–3, use 1 DFI address. And also doing a reindex, which in your case won't be necessary since your issue has been resolved by having 1 DFI address. There are a few reasons for having multiple addresses feature on the app, such as due to user demand & for those running a masternode. On that note, I'll be closing this issue for now, if you've new information, you may reopen this issue with new information (include screenshots) and app logs. Thank you.

nico89-exp commented 3 years ago

HI @izzycsy I checked this with 2.6.2 and now all rewards are shown (both pools I use) and also exported properly. Thanks!