BirthdayResearch / defichain-app

DeFi Blockchain desktop app for Windows, Linux and Mac.
https://defichain.com
MIT License
157 stars 57 forks source link

Improve English language file #1034

Closed solros closed 3 years ago

solros commented 3 years ago

What kind of PR is this?:

/kind fix

What this PR does / why we need it:

I tried to improve the English language texts.

Which issue(s) does this PR fixes?:

The PR fixes a few grammar issues and improves some punctuation and formulations.

Fixes #

Additional comments?:

solros commented 3 years ago

Hi @izzycsy, thanks for reviewing my PR. I have made some changes.

izzycsy commented 3 years ago

Hi @solros , replied! Thank you. Just a something to take note of when suggesting translation related changes. Should it cause the UI to break, it will not be considered a major issue, and the potential UI issue may be left unattended for awhile. Thank you for your contribution and understanding!

solros commented 3 years ago

Hi @izzycsy, I totally understand and agree about the UI and about consistency. Both are super important for a high quality app -- as is correct grammar. I like this project and would like to help. If my suggested changes cause inconsistencies or UI breaks, I would rather clean up and fix these too than keep incorrect grammar in the app. Just let me know what I should do.

izzycsy commented 3 years ago

Hi @solros , thank you. You made make the following changes which are suggested for review. In the mean time, let me seek the team's opinion. Appreciate!

thedoublejay commented 3 years ago

@solros Appreciate the review. Thanks for helping the project!