search

BirthdayResearch / defichain-app

DeFi Blockchain desktop app for Windows, Linux and Mac.
https://defichain.com
MIT License
157 stars 57 forks source link

moved snapshot folder into ~/.defi/ #1066

Closed thunderstorm99 closed 2 years ago

thunderstorm99 commented 2 years ago

What kind of PR is this?:

/kind fix

What this PR does / why we need it:

This PR will move the snapshot folder into ~/.defi/ as opposed to before ~/snapshot I think this is way more predictable as otherwise this might interfere with other programs on the host system. Also it exchanges the deprecated rmdirSync() function for rmSync() (see https://nodejs.org/api/deprecations.html#DEP0147 )

Which issue(s) does this PR fixes?:

Additional comments?:

I tested the resulting .Appimage file on Arch Linux and everything works as expected.

thunderstorm99 commented 2 years ago

If anyone from the dev team could approve the workflow, I'd be grateful.

thedoublejay commented 2 years ago

@thunderstorm99 sorry for the late reply, I think this one will change all directories for all OS. Would you mind just adding a condition only for Linux? So Mac/Windows users won't get affected

thunderstorm99 commented 2 years ago

sorry there was an error on my side. I fixed the error.