search

BirthdayResearch / defichain-app

DeFi Blockchain desktop app for Windows, Linux and Mac.
https://defichain.com
MIT License
157 stars 57 forks source link

Removal of vault collateral not possible if DFI <50% #1100

Closed derstrecker closed 2 years ago

derstrecker commented 2 years ago

Actual behavior: While removing collateral in an active vault with a loan I receive the error message „Error Code 0 400“; in the official DeFiChain Light Wallet. If DFI amount is less than 50%, it is not possible to remove any other collateral, to change this. For example removing dBTC to balance the DFI part >51% is not possible. Only if I add DFI to be the vault >50%, then only I can remove any other collateral. Doesn't make sense.

Expected behavior: Should remove Collateral.

How to reproduce it (as minimally and precisely as possible): Remove Collateral in the official DeFiChain Light Wallet. Collateral 49% DFI and 51% dBTC.

What are your environment parameters? DeFiCh/app Version: DFX Wallet v0.17.1 Operating System (OS): iOS mobile – RAM (GB): - – CPU (Intel Core i5/i7/etc.): iPhone 12 Pro Max Current free storage capacity: enough

defichain-bot commented 2 years ago

@derstrecker: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

In the meantime, you can:

  1. Checkout DeFiChain’s Github issue page to see if your issue has already been reported
  2. Submit any logs if you have them, this will greatly expedite the process for us.
  3. You can also join our Telegram or Reddit community channels.
Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/app/blob/master/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
wmbst commented 2 years ago

I guess you are writing about the mobile wallet: https://github.com/DeFiCh/wallet This part is the desktop full node app. Perhaps you can move it or copy it to the other branch.

Actual version in the app store is 0.19.2 Can you update and check whether the issue is still there?

derstrecker commented 2 years ago

Yes, did that, thanks :)