BirthdayResearch / defichain-app

DeFi Blockchain desktop app for Windows, Linux and Mac.
https://defichain.com
MIT License
157 stars 57 forks source link

Broken Wallets shouldn´t be autoloaded #1186

Closed trimat1 closed 2 years ago

trimat1 commented 2 years ago

Actual behavior:

Wallet (acutally Node) crashes when loading a broken walletfile. Therefore not possible to open app or load other wallet

Expected behavior:

If Walletfile creates Nodecrash then walletfile shouldn´t be autoloaded. (defi.conf) Or Node shouldn´t crash when corrupt walletfile is loaded.

How to reproduce it (as minimally and precisely as possible):

  1. Get somehow corrupt walletfile (did´t remember exactly but probably just copy paste the .dat file or play with import keys...)
  2. Node crashes when loaded -> APP stalls
  3. Restart App doesn´t work (as Node crashes on startup)
  4. No option to deselect the broken walletfile (except if you know in the defi.conf file)

What are your environment parameters?

Anything else we need to know?

defichain-bot commented 2 years ago

@trimat1: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

In the meantime, you can:

  1. Checkout DeFiChain’s Github issue page to see if your issue has already been reported
  2. Submit any logs if you have them, this will greatly expedite the process for us.
  3. You can also join our Telegram or Reddit community channels.
Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/app/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
dusterhub commented 2 years ago

@trimat1 I might have a problem with a corrupted wallet.dat file - so I am interested in what you just mentioned: "Get somehow corrupt walletfile (did´t remember exactly but probably just copy paste the .dat file or play with import keys...)"

--> how can a walletfile.dat get corrupted? do you need to copy more than just the .dat file (+password) for a healthy backup?

Thanks in advance

trimat1 commented 2 years ago

@dusterhub i'm not entirely sure how to make a probper backup. usually i copy the whole folder. But i also get there sometimes problems when loading on other node.

so maybe somebody with proper experience could answer that...

izzycsy commented 2 years ago

Hi @trimat1 @dusterhub , could you attached your app * node logs for investigation please?

1 App logs 2 Compress

In the mean time, please keep a copy of your wallets folder + passphrase — keep it safe. To find wallet.dat:


Windows —
C: \Users\<username>\AppData\Roaming\DeFi Blockchain\wallets


Mac — Go to Folder:
 /Users/<username>/Library/Application Support/Defi/wallets

wallet dat location
izzycsy commented 2 years ago

Hi @trimat1 @dusterhub , update v2.13.0 is out, this is a mandatory update. Kindly backup wallet and read through the release notes before updating.

You may refer to this guide on How to Restore Wallet from Backup #988.

Do give a thumbs up to this comment if your issue has been resolved, otherwise, you may reopen this issue with new information (include screenshots) and app logs. Thank you.