Swap with DFI displays incorrect pair

pierregee commented 3 years ago

What happened:

The Pool Swap Screen displayed the incorrect pair (didn't updated from the previous screen)

What you expected to happen:

The Pool Swap Screen should always display the correct pair

How to reproduce it (as minimally and precisely as possible):

Navigate to DEX -> dETH-DFI -> Swap Tokens
Navigate to Balances -> dBTC -> Swap with DFI Issue: The screen did not update the pair in Pool Swap Screen and still displays dETH-DFI instead of dBTC-DFI

Anything else we need to know?:

defichain-bot commented 3 years ago

@pierregee: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/wallet/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.

defichain-bot commented 3 years ago

@pierregee: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/wallet/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.

izzycsy commented 2 years ago

Acceptance Criteria: Swap should be accordingly to selected pair

Android:

[x] Balances > Swap > DFI (UTXO) to DFI (Token) displayed > vice versa
[x] Balances > dETH > Swap with DFI > dETH to DFI displayed > vice versa
[x] Balances > dBTC > Swap with DFI > dBTC to DFI displayed > vice versa
[x] Balances > dUSDT > Swap with DFI > dUSDT to DFI displayed > vice versa

iOS:

[x] Balances > Swap > DFI (UTXO) to DFI (Token) displayed > vice versa
[x] Balances > dETH > Swap with DFI > dETH to DFI displayed > vice versa
[x] Balances > dBTC > Swap with DFI > dBTC to DFI displayed > vice versa
[x] Balances > dUSDT > Swap with DFI > dUSDT to DFI displayed > vice versa

BirthdayResearch / defichain-wallet