BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
126 stars 47 forks source link

To add `commission fee` #1482

Open izzycsy opened 3 years ago

izzycsy commented 3 years ago

What would you like to be added:

• To add commission fee to total fees

Why is this needed:

• Currently, LW does not include commission fees.

defichain-bot commented 3 years ago

@izzycsy: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/wallet/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
kyleleow commented 3 years ago

@dwivedinalin did you close this ticket by accident?

dwivedinalin commented 3 years ago

Acceptance Criteria: Commission fee should be added to the total fees on a Swap transaction

Android: DEX > SWAP TOKENS > Verify commission fee is added to total fees:

iOS: DEX > SWAP TOKENS > Verify commission fee is added to total fees:

kyleleow commented 3 years ago

On hold to wait for blockchain side to release an RPC that returns the commission fee