BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

`Loans` - UI on "Select any token to add" is cluttered #1811

Open izzycsy opened 2 years ago

izzycsy commented 2 years ago

211224 v0 22 0 - iOS:Android - Loans - Your vaults - EDIT COL - Select token to add UI3

211224 v0 22 0 - iOS:Android - Loans - Your vaults - EDIT COL - Select token to add UI1

https://user-images.githubusercontent.com/65014479/147336344-44477d16-564d-4baa-bcbd-4783fe476b2a.mp4

What happened:

• UI in pop up modal is too cluttered for "Select token to add X"

What you expected to happen:

• Padding for each element

How to reproduce it (as minimally and precisely as possible):

• Switch to German language in app > Loans > click into vault > EDIT COLLATERALS > + ADD TOKEN AS COLLATERAL > check UI on "Select any token to add" screen

Anything else we need to know?:

Device Model: iPhone 13 & Redmi Note 10 Pro OS: iOS & Android DeFi app version: 0.22.0

defichain-bot commented 2 years ago

@izzycsy: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/wallet/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
defichain-bot commented 2 years ago

@izzycsy: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/wallet/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
thedoublejay commented 2 years ago

To be able to do this, you need to have some DFI

  1. Loans Screen
  2. Create a vault
  3. Click on a vault to open Vault detail screen
kyleleow commented 2 years ago

Need to see what was the issue, couldn't reproduce on my android and ios devices image image

chloezxyy commented 2 years ago

Managed to reproduce it on the V.022.0 version (production code), but on the local version which is V2.23.2, this issue won’t be resolved until we push current code to production @thedoublejay