Add deep links for sending assets

mbochmann commented 2 years ago

What would you like to be added:

I would like to add the ability to directly deep link the SendConfirmationScreen and SendScreen.

Why is this needed:

It allows to request a transaction directly from the web with an url either by an unknown amount with referencing the SendScreen or with a fixed amount by referencing the SendConfirmationScreen.

What have to be changed:

Primarily the token param have to be made optional and have to be resolved by the Screen if the optional new parameter symbol is available (and token is not available / undefined) in the link because token unfortunately resolves as object in the url.
Additionally some more params in SendConfirmationScreen have to be made optional and resolved by the Screen if not available by the url like the token price.
In app.json, the scheme have to be changed to a unique scheme. My proposal is: defichain.
A warning message have to be added to the screens if they were called by a deep link to explain the user what he will do if he confirms the transaction.

Result:

The result would be the possibility to add an url to a website like defichain://app/portfolio/send/confirm?symbol=DFI&amount=5&destination=mydefichainaddress&callbackUrl={url} for directly requesting 5 DFI target: SendConfirmationScreen

or

defichain://app/portfolio/send?symbol=DFI&amount=5&destination=mydefichainaddress&callbackUrl={url} for asking 5 DFI with the possibility to change the parameters target: SendScreen

callbackUrl: url which will be pinged once the transaction is sent to the network with a placeholder {txid} which will be replaced by the transaction-id.

If accepted, I would like to implement it.

github-actions[bot] commented 2 years ago

@mbochmann: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/wallet/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.

github-actions[bot] commented 2 years ago

@mbochmann: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/wallet/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.

github-actions[bot] commented 2 years ago

@mbochmann: Thanks for opening an issue, an appropriate priority will be added soon.

The priority labels can be added by foundation members by writing /priority [type] in a comment.

Details

I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/wallet/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.

BirthdayResearch / defichain-wallet