`expo-jest` is configured to `native` only, we should test all platform.

BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.

MIT License

125 stars 46 forks source link

`expo-jest` is configured to `native` only, we should test all platform. #339

Open fuxingloh opened 3 years ago

fuxingloh commented 3 years ago

What would you like to be added:

https://github.com/DeFiCh/wallet/blob/6038722d3c2bbe22d0887772c64324f17cc51ad7/jest.config.js#L2

https://github.com/expo/expo/tree/master/packages/jest-expo#mixing-runners

-  preset: 'jest-expo',
+  projects: [
+     { preset: "jest-expo/web" },
+     { preset: "jest-expo/ios" },
+     { preset: "jest-expo/android"}
+  ]

This will run the test 3x on each platform.

/area core workflow

defichain-bot commented 3 years ago

@fuxingloh: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/wallet/blob/main/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.