BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

feature(ui-ux): address book ui for transfer domain #4042

Closed chloezxyy closed 1 year ago

chloezxyy commented 1 year ago

What this PR does / why we need it:

  1. New UI design for address book for transfer domain.
  2. Updated design for Address book bottom sheet in Portfolio page to display default generatedAddress label from the redux store. image
  3. To display the correct address labels with evm svg background for Send and SendConfirm screen
  4. To display correct address label on Portfolio screen

Which issue(s) does this PR fixes?:

Fixes # ORD-303

Additional comments?:

WIP - E2E

Developer Checklist:

github-actions[bot] commented 1 year ago

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2002,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2002,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2002,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2002,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2002,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}
github-actions[bot] commented 1 year ago

Build preview for DeFiChain Wallet is ready!

Built with commit eaafb44ad26118131275c10f09ca7e48d9063e3a

https://expo.io/@defichain/wallet?release-channel=pr-preview-4042

chloezxyy commented 1 year ago

LGTM with just two things to look at!

  1. What's the expectation when you delete a default address, can it remain blank?
image
  1. When you go to settings -> Address Book -> there is an arrow which makes the user think it's clickable
image

Updated the following:

  1. No, address label won't be saved if the label is an empty string
  2. Hid the arrow if the user comes from the Settings page instead of the Send page