BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

fix(ui-ux): address book bottom sheet in portfolio page #4046

Closed chloezxyy closed 11 months ago

chloezxyy commented 11 months ago

What this PR does / why we need it:

Add checks if address label is trimmed Add label validation check to disallow address label if its existing

Which issue(s) does this PR fixes?:

Fixes #4042

Additional comments?:

Developer Checklist:

github-actions[bot] commented 11 months ago

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2013,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2013,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2013,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2013,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2013,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}
github-actions[bot] commented 11 months ago

Build preview for DeFiChain Wallet is ready!

Built with commit c967168efdbdc9d534a65c7743cc6a62cdded141

https://expo.io/@defichain/wallet?release-channel=pr-preview-4046