BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

fix(ui-ux): choose address by domain #4065

Closed pierregee closed 11 months ago

pierregee commented 11 months ago

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes DFC-346

Additional comments?:

Developer Checklist:

linear[bot] commented 11 months ago
DFC-346 Transfer Domain : From address is incorrect when sending tokens from EVM to DVM

#### What happened? From address is displaying DVM address instead of EVM address during send (EVM to DVM) #### What did you expect to happen? From address should display DVM address during send (EVM to DVM) #### How to reproduce it (as minimally and precisely as possible): [Send_EVM_DVM_From_address_incorrect.mov](https://uploads.linear.app/ed7438a1-0dae-40df-9d75-9ba5b0ba89d2/cbfabbea-d996-4baf-9849-085fdc8a1c27/7acaee5c-17b7-488b-b3e4-d4ca3a8e369d) #### Anything else that the team needs to know?

github-actions[bot] commented 11 months ago

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2013,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2013,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2013,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2013,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2013,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}
github-actions[bot] commented 11 months ago

Build preview for DeFiChain Wallet is ready!

Built with commit cb0fcb5de106e979e8cfee3d570396ede83f9e99

https://expo.io/@defichain/wallet?release-channel=pr-preview-4065