BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

fix(ui-ux): fixed address title in address input screen #4070

Closed fullstackninja864 closed 1 year ago

fullstackninja864 commented 1 year ago

What this PR does / why we need it:

fixed alignment of to address label

image

Which issue(s) does this PR fixes?:

Fixes DFC-349, DFC-351

Additional comments?:

Developer Checklist:

github-actions[bot] commented 1 year ago

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2013,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2013,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2013,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2013,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2013,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}
github-actions[bot] commented 1 year ago

Build preview for DeFiChain Wallet is ready!

Built with commit 35a703ca01545f3f14113cafbc811d3a2723a299

https://expo.io/@defichain/wallet?release-channel=pr-preview-4070

linear[bot] commented 1 year ago
DFC-349 Transfer Domain: To address is not displayed during Send - DVM <> EVM

#### What happened? To address is not displayed during Send - DVM to EVM & vice versa #### What did you expect to happen? To address should be displayed along with colour gradient in confirm screen while sending tokens from DVM to EVM address and vice versa #### How to reproduce it (as minimally and precisely as possible): [Screenshot 2023-10-17 at 12.04.28 PM.png](https://uploads.linear.app/ed7438a1-0dae-40df-9d75-9ba5b0ba89d2/72cae43f-faaa-407d-bfd0-9d0bc9b8fbfb/b7772d6c-5a3b-4eb6-9959-680027532438) Steps to replicate: [Send_DV_EVM_Empty_To_Address.mov](https://uploads.linear.app/ed7438a1-0dae-40df-9d75-9ba5b0ba89d2/b5ec6124-f5b2-4a60-98d9-7c2aa66de8e3/829ba25f-f2c2-4627-bead-b445b4c331a4) AddressBook: [Address_Book.mov](https://uploads.linear.app/ed7438a1-0dae-40df-9d75-9ba5b0ba89d2/62677a8f-29a4-4e92-b1f1-bf92ea51a0fb/6561b72e-b77b-42db-8863-47ae2ced498d) #### Anything else that the team needs to know?

linear[bot] commented 1 year ago
DFC-351 Transfer Domain : Error when sending 8 decimal tokens from EVM to DVM address

#### What happened? Encountering "`transferdomain evm tx failed to pre-validate invalid function signature input in evm tx (code 16).`" error while sending 8 decimal tokens from EVM to DVM. #### What did you expect to happen? #### How to reproduce it (as minimally and precisely as possible): Send tokens with 8 decimals from EVM to DVM address [Screenshot 2023-10-17 at 5.37.35 PM.png](https://uploads.linear.app/ed7438a1-0dae-40df-9d75-9ba5b0ba89d2/791dc5ad-37ac-4b8d-a3d1-161fd767180f/17b5ab07-46b7-44cc-a1ca-46710247d613) #### Anything else that the team needs to know?