BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

fix(ui-ux): hide Get DFI btn on empty portfolio screen #4080

Closed fullstackninja864 closed 10 months ago

fullstackninja864 commented 10 months ago

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes DFC-360

Additional comments?:

Developer Checklist:

linear[bot] commented 10 months ago
DFC-360 Get DFI in EVM flow - User is not redirected to Convert flow upon clicking Get DFI

#### What happened? 1. Match contents as expected. Rename CTA to "Get DFI-EVM" 2. Step3 - Convert to DFi-EVM tokens is missing 3. There are DFI tokens but user is not redirected to convert flow upon clicking "Get DFI" #### What did you expect to happen? [IMG_11A8E9508E3E-1.jpeg](https://uploads.linear.app/ed7438a1-0dae-40df-9d75-9ba5b0ba89d2/4a296af6-e683-4476-9d77-4abc4cae1b78/ccef0e2e-31b1-4755-ae95-6396d47d3c71) [IMG_3A13DFC716E7-1.jpeg](https://uploads.linear.app/ed7438a1-0dae-40df-9d75-9ba5b0ba89d2/7d7cf7c1-947b-4839-b5da-c939ade320aa/cd271e7e-a4d0-4459-ba6c-4f5bc9398cd3) #### How to reproduce it (as minimally and precisely as possible): #### Anything else that the team needs to know?

github-actions[bot] commented 10 months ago

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}
github-actions[bot] commented 10 months ago

Build preview for DeFiChain Wallet is ready!

Built with commit 56b51f9f1f560604f24bd55cc527ed00b57150dd

https://expo.io/@defichain/wallet?release-channel=pr-preview-4080