BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

fix(core): handle auto-conversion of utxo to dfi token #4082

Closed lykalabrada closed 10 months ago

lykalabrada commented 10 months ago

What this PR does / why we need it:

Handle auto-conversion of UTXO into DFI token when user is sending to an EVM address, and has enough UTXO but not enough DFI token.

Which issue(s) does this PR fixes?:

Fixes DFC-363, DFC-353

Additional comments?:

Developer Checklist:

linear[bot] commented 10 months ago
DFC-363 Transfer Domain: Insufficient Balance error during send when there is sufficient balance

#### What happened? Insufficient Balance error during send from DFI to EVM DFI when there is sufficient tokens available #### What did you expect to happen? #### How to reproduce it (as minimally and precisely as possible): [Send_insufficient_balance.mp4](https://uploads.linear.app/ed7438a1-0dae-40df-9d75-9ba5b0ba89d2/846e8189-e2c9-4acc-b3a0-ccd280ac76a6/34fa1888-af86-4ec5-9098-6a648157cb0b) #### Anything else that the team needs to know?

github-actions[bot] commented 10 months ago

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}
github-actions[bot] commented 10 months ago

Build preview for DeFiChain Wallet is ready!

Built with commit 20a6860ec69c5dda0bb8e85a10dc325881e8c78c

https://expo.io/@defichain/wallet?release-channel=pr-preview-4082

linear[bot] commented 10 months ago
DFC-353 UI/UX Improvement: Transfer Domain DFI -> DFI EVM (Doesn’t auto convert balance DFI UTXO -> DFI)

Transfer Domain DFI -> DFI EVM (Doesn’t auto convert balance DFI UTXO -> DFI) * In my balance, I have combined 90 DFI token (50) + UTXO (40) * I can only transfer the 40 DFI Token -> DFI EVM as of now The UX improvement should be → The Convert screen display I have `89.90000000 DFI`so user doesn't have to worry that the DFI is in UTXO form