BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

fix(core): skip eth provider for transfer domain #4095

Closed lykalabrada closed 10 months ago

lykalabrada commented 10 months ago

What this PR does / why we need it:

Issue with Invalid nonce still persists on Android devices, probably because of eth rpc provider not loading properly with context. Reverting to previous version wherein transfer domain function is not dependent on context.

Which issue(s) does this PR fixes?:

Fixes DFC-364

Additional comments?:

Developer Checklist:

github-actions[bot] commented 10 months ago

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}
linear[bot] commented 10 months ago
DFC-364 Transfer Domain : Invalid Nonce error upon sending dtokens to EVM address

#### What happened? Transfer Domain : Invalid Nonce error upon sending dtokens to EVM address #### What did you expect to happen? #### How to reproduce it (as minimally and precisely as possible): dGOOGL from DVM to EVM address [Error_sending_dtokens_evm.jpg](https://uploads.linear.app/ed7438a1-0dae-40df-9d75-9ba5b0ba89d2/659b8428-1ab4-49c6-9cef-26a14e0260cf/ef044210-59ac-461b-90de-b03134efab2e) #### Anything else that the team needs to know?

github-actions[bot] commented 10 months ago

Build preview for DeFiChain Wallet is ready!

Built with commit df7cdcfa3e3a8fc9c434ff5d9de65e532957f13c

https://expo.io/@defichain/wallet?release-channel=pr-preview-4095