BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

fix(ui-ux): display evm address as from on convert #4099

Closed lykalabrada closed 10 months ago

lykalabrada commented 10 months ago

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes DFC-383

Additional comments?:

Developer Checklist:

linear[bot] commented 10 months ago
DFC-383 [ADR] - From address is incorrect when converting tokens from EVM to DVM

**What happened?** From address is incorrect when converting tokens from EVM to DVM. Displaying EVM address currently [image.png](https://uploads.linear.app/ed7438a1-0dae-40df-9d75-9ba5b0ba89d2/244dc571-3b34-41dd-885c-fb90d575311e/ca551072-14b9-4b79-a75a-1460ca027877) **What did you expect to happen?** **How to reproduce it (as minimally and precisely as possible):** 1. User is in EVM network 2. Click on convert quick link and convert token from EVM to DVM 3. In confirm screen, From address is displaying DVM address

github-actions[bot] commented 10 months ago

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}
github-actions[bot] commented 10 months ago

Build preview for DeFiChain Wallet is ready!

Built with commit 7ce24ba9c5d19743ecae5f03b7c1223c660130b7

https://expo.io/@defichain/wallet?release-channel=pr-preview-4099