BirthdayResearch / defichain-wallet

DeFiChain Wallet. The DeFi Blockchain Light Wallet for iOS, Android & Web.
MIT License
125 stars 46 forks source link

fix(ui-ux): token name and logo incorrect in convert screen #4108

Closed fullstackninja864 closed 10 months ago

fullstackninja864 commented 10 months ago

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes DFC-388 DFC-380

Additional comments?:

Developer Checklist:

linear[bot] commented 10 months ago
DFC-388 Transfer Domain :[ADR] - Token name and logo incorrect in convert screen (EVM Network)

#### What happened? Token name and logo incorrect in convert screen (EVM Network) #### What did you expect to happen? To Convert logo and token name should be of DVM network [linear_gradient_incorrect_dmst.jpg](https://uploads.linear.app/ed7438a1-0dae-40df-9d75-9ba5b0ba89d2/46c27ab6-bf18-437f-9317-087a00ecb49d/f5f39b9b-524c-4af6-863a-7a3cfa4c80a3) [logo\_ incorrect.mp4](https://uploads.linear.app/ed7438a1-0dae-40df-9d75-9ba5b0ba89d2/86326c9b-be1c-47af-aa0c-7285f300eb9c/9fa10a47-f582-41d7-9ce1-163746fcca37) #### How to reproduce it (as minimally and precisely as possible): #### Anything else that the team needs to know?

github-actions[bot] commented 10 months ago

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 2028,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 0
}
github-actions[bot] commented 10 months ago

Build preview for DeFiChain Wallet is ready!

Built with commit 251bc61cead6517caed948ef5b60b06e65a925e2

https://expo.io/@defichain/wallet?release-channel=pr-preview-4108

linear[bot] commented 10 months ago
DFC-380 Transfer Domain : [iOS] - "Verified" is displayed instead of "Verified DVM address"in Send screen

#### What happened? 1. Verified is displayed instead of "Verified Defichain (DVM) address"in Send screen 2. Disclaimer " You are sending assets to a DFI address. EVM asset gets converted to DVM. Learn more" is missing Issue 2 happens for EVM → DVM & DVM → EVM. Fix required for both flows. #### "What did you expect to happen? [https://www.figma.com/file/2R0O9elwIN3fkkBnxLsUMM/Mobile-Light-Wallet---Handover-File?type=design&node-id=14331-178952&mode=design&t=eNiZ6gRY2hAwhYTW-4](https://www.figma.com/file/2R0O9elwIN3fkkBnxLsUMM/Mobile-Light-Wallet---Handover-File?type=design&node-id=14331-178952&mode=design&t=eNiZ6gRY2hAwhYTW-4) #### How to reproduce it (as minimally and precisely as possible): 1. User is in EVM network 2. User clicks on send quick link 3. Selects token and scans QR code for DVM address [Verified_DVM_Address_Expected.jpeg](https://uploads.linear.app/ed7438a1-0dae-40df-9d75-9ba5b0ba89d2/ec5a2418-a737-42ee-8ddb-0e46e86cf070/09f18c92-bfbf-49b4-993a-e41aa7432192) #### Anything else that the team needs to know?

lykalabrada commented 10 months ago

Closing, similar PR has been opened instead https://github.com/BirthdayResearch/defichain-wallet/pull/4111/files